Skip to content

Commit 883c575

Browse files
committed
fix dynamic contract tests
1 parent 02bc9f0 commit 883c575

File tree

4 files changed

+4
-7
lines changed

4 files changed

+4
-7
lines changed

packages/thirdweb/src/contract/deployment/deploy-dynamic.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,7 @@ import { getContract } from "../contract.js";
99
import { deployCloneFactory } from "./utils/bootstrap.js";
1010

1111
describe.runIf(process.env.TW_SECRET_KEY)("deploy dynamic", () => {
12-
// TODO: Fix this test
13-
it.skip.sequential(
12+
it.sequential(
1413
"should deploy dynamic contract with extensions",
1514
async () => {
1615
await deployCloneFactory({

packages/thirdweb/src/extensions/dynamic-contracts/write/installPublishedExtension.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ import { sendTransaction } from "../../../transaction/actions/send-transaction.j
1111
import { installPublishedExtension } from "./installPublishedExtension.js";
1212

1313
describe.runIf(process.env.TW_SECRET_KEY)("install extension", () => {
14-
// TODO: Fix this test
15-
it.skip.sequential(
14+
it.sequential(
1615
"should install extension to a dynamic contract",
1716
async () => {
1817
await deployCloneFactory({

packages/thirdweb/src/extensions/dynamic-contracts/write/uninstallExtension.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ import { deployPublishedContract } from "../../prebuilts/deploy-published.js";
1111
import { uninstallExtension } from "./uninstallExtension.js";
1212

1313
describe.runIf(process.env.TW_SECRET_KEY)("uninstall extension", () => {
14-
// TODO: Fix this test
15-
it.skip.sequential(
14+
it.sequential(
1615
"should uninstall extension from a dynamic contract",
1716
async () => {
1817
await deployCloneFactory({

packages/thirdweb/src/extensions/prebuilts/deploy-published.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ export async function deployContractfromDeployMetadata(
215215
if (
216216
deployMetadata.routerType === "dynamic" &&
217217
deployMetadata.defaultExtensions &&
218-
!isZkSyncChain(chain)
218+
!(await isZkSyncChain(chain))
219219
) {
220220
for (const e of deployMetadata.defaultExtensions) {
221221
await getOrDeployInfraForPublishedContract({

0 commit comments

Comments
 (0)