Skip to content

Commit 8828df0

Browse files
committed
Dashboard: Fix project links footer not sticked to the bottom on short pages (#7909)
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the layout of the `ProjectPage` component by modifying the class names of certain `div` elements to improve styling and spacing. ### Detailed summary - Changed the class name of the main `div` from `pb-20` to `grow`. - Added a new `div` with class `h-20` to provide spacing. - Updated the class name of the footer `div` from `mt-20` to `mt-auto` for better positioning. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Style** - Updated project page layout for more consistent spacing and alignment. - Standardized vertical spacing and removed conditional bottom padding to ensure predictable layout across views. - Footer now aligns to the bottom with automatic spacing, improving visual balance on longer pages. - Added a vertical spacer to separate main content from the footer for clearer hierarchy and readability. - No changes to public APIs or functionality; visual/spacing adjustments only. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent c6150be commit 8828df0

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

apps/dashboard/src/@/components/blocks/project-page/project-page.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ type ProjectPageProps = {
2121

2222
export function ProjectPage(props: React.PropsWithChildren<ProjectPageProps>) {
2323
return (
24-
<div className={cn("flex flex-col pb-20", props.footer && "pb-0")}>
24+
<div className="flex flex-col grow">
2525
<div className={cn(!props.tabs && "border-b")}>
2626
<ProjectPageHeader {...props.header} />
2727
{props.tabs && (
@@ -33,8 +33,9 @@ export function ProjectPage(props: React.PropsWithChildren<ProjectPageProps>) {
3333
</div>
3434

3535
<main className="container max-w-7xl pt-6">{props.children}</main>
36+
<div className="h-20" />
3637
{props.footer && (
37-
<div className="border-t mt-20">
38+
<div className="border-t mt-auto">
3839
<ProjectPageFooter {...props.footer} />
3940
</div>
4041
)}

0 commit comments

Comments
 (0)