fix clean error handling and lint issues

Author: GiselleNessi

apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/support/_components/SupportCaseDetails.tsx

@@ -71,36 +71,29 @@ function SupportCaseDetails({ ticket, team }: SupportCaseDetailsProps) {
     // Set degraded state for warning banner
     setStatusCheckFailed(true);
 
-    // Throw a custom error that React Query will catch, but the UI will handle gracefully
-    // This prevents treating the error as "no feedback exists" which could cause duplicates
-    throw new Error(`Status check failed: ${errorMessage}`);
+    // Don't throw; let the query return a safe fallback to avoid retries and duplicate analytics
+    return;
   };
 
   // Check if feedback has already been submitted for this ticket
   const feedbackStatusQuery = useQuery({
     queryKey: ["feedbackStatus", ticket.id],
     queryFn: async () => {
-      try {
-        const result = await checkFeedbackStatus(ticket.id);
-        if ("error" in result) {
-          // Use shared error handler to maintain consistent behavior
-          handleStatusCheckError(result.error);
-          // This line is unreachable but needed for TypeScript
-          return false;
-        }
-
-        // Clear degraded state on success
-        if (statusCheckFailed) setStatusCheckFailed(false);
-
-        return result.hasFeedback;
-      } catch (error) {
-        // Use shared error handler to maintain consistent behavior
-        handleStatusCheckError(error);
+      const result = await checkFeedbackStatus(ticket.id);
+      if ("error" in result) {
+        handleStatusCheckError(result.error);
+        return false; // Non-blocking: allow feedback submission despite status check failure
       }
+
+      // Clear degraded state on success
+      if (statusCheckFailed) setStatusCheckFailed(false);
+
+      return result.hasFeedback;
     },
     enabled: ticket.status === "closed",
     staleTime: 60_000,
     gcTime: 5 * 60_000,
+    retry: 1, // Reduce retries since we want non-blocking behavior
   });
 
   const feedbackSubmitted = feedbackStatusQuery.data ?? false;