Skip to content

Cleanup, fix tests, config update #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2025
+53 −58
Merged

Cleanup, fix tests, config update #691

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb1d4ad
deploy config update
kumaryash90 Aug 8, 2025
2fc109f
fix tests
kumaryash90 Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/prebuilts/drop/DropERC721C.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ contract DropERC721C is
uint256 private constant MAX_BPS = 10_000;

address public constant DEFAULT_FEE_RECIPIENT = 0x1Af20C6B23373350aD464700B5965CE4B0D2aD94;
uint16 private constant DEFAULT_FEE_BPS = 100;
uint16 private constant DEFAULT_FEE_BPS = 50;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Default protocol fee reduced to 50 bps — verify downstream assumptions and update docs/tests

This halves the protocol take-rate (1% → 0.5%). Please confirm no tests, deployment configs, UI copy, or partner integrations assume 100 bps.

Run this to find assumptions tied to 100 bps / 1% and the default fee in the repo:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Find spots referencing the default protocol fee or old 1% value.
rg -n -S 'DEFAULT_FEE_BPS|100 bps|100bps|1% default|protocol fee|platformFeesTw' \
  -g '!node_modules' -g '!dist' -g '!build' -g '!out'

# Cross-check usage around claim price collection and recipient.
rg -n -S '_collectPriceOnClaim|DEFAULT_FEE_RECIPIENT' \
  -g '!node_modules' -g '!dist' -g '!build' -g '!out'

Length of output: 17309

Default protocol fee halved to 50 bps — update tests assuming 100 bps

Several marketplace tests hardcode a 1% (100 bps) default fee and must be revised to reflect the new 50 bps default:

• src/test/marketplace/Offers.t.sol:364
• src/test/marketplace/DirectListings.t.sol:590
• src/test/marketplace/EnglishAuctions.t.sol:425
• src/test/marketplace/english-auctions/_payout/_payout.t.sol:267
• src/test/marketplace/direct-listings/_payout/_payout.t.sol:292

Action items:

  • Adjust platformFeeBps values: for “100% total fees” use 10 000 – 50 = 9950 instead of 9900; for “99.99% total” use 9999 – 50 = 9949 instead of 9899.
  • Update accompanying comments to reference 50 bps default.
  • Audit any remaining docs, UI copy, deployment configs, or partner integrations for references to a 1% default fee.
🤖 Prompt for AI Agents 
In contracts/prebuilts/drop/DropERC721C.sol at line 74, the default protocol fee
has been changed from 100 bps to 50 bps. You need to update all related
marketplace test files listed in the comment to reflect this change by adjusting
platformFeeBps values accordingly: use 9950 instead of 9900 for 100% total fees
and 9949 instead of 9899 for 99.99% total fees. Also, update any comments in
those tests to mention the new 50 bps default fee and audit other documentation,
UI text, deployment configs, or partner integrations for references to the old
1% fee and update them as needed.


/// @dev Constant value representing the ERC721 token type for signatures and transfer hooks
uint256 constant TOKEN_TYPE_ERC721 = 721;
Expand Down