Implement BillingId support #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en performing token transactions
…sition?) and fix an identified whitespace issue
|
... and fixed Travis, though reported coverage isn't great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some organisations card billing tokens are shared across systems and it's easier to use a local billing ID (like the customer number) instead of the DPS billing ID. This is explicitly supported by DPS through the BillingId parameter which the library can't currently handle, as the card reference is presumed to be the DpsBillingId.
I've implemented it as an alternative billingId parameter here, though it might be neater to continue to use cardReference with either an option to say that it's a BillingId, or a prefix on the reference to say so. That would be more in keeping with the Omnipay interface...
I haven't written tests for this yet, I thought I'd see whether this is the preferred approach first. Happy to write tests once we have a solid approach.