Skip to content

Making System Metric's PSRAM chart creation conditional #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

Making System Metric's PSRAM chart creation conditional #95

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb180fb
Fixed PSRAM chart creation
hmbacher Sep 15, 2025
26a0d0d
Fixed PSRAM metric
hmbacher Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions interface/src/routes/system/metrics/SystemMetrics.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<script lang="ts">
import { onDestroy, onMount } from 'svelte';
import { page } from '$app/state';
import { onMount } from 'svelte';
import SettingsCard from '$lib/components/SettingsCard.svelte';
import { slide } from 'svelte/transition';
import { cubicOut } from 'svelte/easing';
Expand All @@ -11,18 +10,21 @@

Chart.register(...registerables);

let heapChartElement: HTMLCanvasElement = $state();
let heapChartElement: HTMLCanvasElement | undefined = $state();
let heapChart: Chart;

let psramChartElement: HTMLCanvasElement = $state();
let psramChartElement: HTMLCanvasElement | undefined = $state();
let psramChart: Chart;

let filesystemChartElement: HTMLCanvasElement = $state();
let filesystemChartElement: HTMLCanvasElement | undefined = $state();
let filesystemChart: Chart;

let temperatureChartElement: HTMLCanvasElement = $state();
let temperatureChartElement: HTMLCanvasElement | undefined = $state();
let temperatureChart: Chart;

// Check if PSRAM data is available
let hasPsramData = $derived(Math.max(...$analytics.psram_size) > 0);

onMount(() => {
heapChart = new Chart(heapChartElement, {
type: 'line',
Expand Down Expand Up @@ -97,7 +99,10 @@
}
}
});
psramChart = new Chart(psramChartElement, {

// Only create PSRAM chart if PSRAM data is available
if (hasPsramData) {
psramChart = new Chart(psramChartElement, {
type: 'line',
data: {
labels: $analytics.uptime,
Expand All @@ -107,7 +112,7 @@
borderColor: daisyColor('--color-primary'),
backgroundColor: daisyColor('--color-primary', 50),
borderWidth: 2,
data: $analytics.free_psram,
data: $analytics.used_psram,
yAxisID: 'y'
}
]
Expand Down Expand Up @@ -162,6 +167,8 @@
}
}
});
}

filesystemChart = new Chart(filesystemChartElement, {
type: 'line',
data: {
Expand Down Expand Up @@ -304,7 +311,7 @@
heapChart.update('none');
heapChart.options.scales.y.max = Math.round(Math.max(...$analytics.total_heap));

if (Math.max(...$analytics.psram_size)) {
if (hasPsramData) {
psramChart.data.labels = $analytics.uptime;
psramChart.data.datasets[0].data = $analytics.used_psram;
psramChart.update('none');
Expand Down Expand Up @@ -365,7 +372,7 @@
<canvas bind:this={heapChartElement}></canvas>
</div>
</div>
{#if Math.max(...$analytics.psram_size)}
{#if hasPsramData}
<div class="w-full overflow-x-auto">
<div
class="flex w-full flex-col space-y-1 h-60"
Expand Down