Add student feedback modal UI #613
Conversation
Summary of ChangesHello @Ganapathy-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new student feedback mechanism by adding a dedicated modal UI. This modal allows users to provide ratings and detailed comments on courses, enhancing the platform's ability to gather valuable insights into course quality and mentor effectiveness. The changes ensure that the feedback form appears contextually when a student completes a course, streamlining the feedback collection process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request introduces a new feedback form modal to collect student feedback for courses. The changes include adding a new HTML file for the feedback modal, modifying the content heading and scripts files, and including the feedback modal in the PDF template. I have provided feedback on the HTML structure and accessibility of the modal.
| How the mentor of the course taught complex problems ? | ||
| </label> | ||
|
|
||
| <textarea id="hs-pro-shwprmar" required class="py-3 px-4 block w-full border-gray-200 rounded-lg sm:text-sm placeholder:text-gray-400 focus:border-blue-500 focus:ring-blue-500 disabled:opacity-50 disabled:pointer-events-none dark:bg-neutral-800 dark:border-neutral-700 dark:text-neutral-400 dark:placeholder-neutral-600 dark:focus:ring-neutral-600 min-h-[4rem]" rows="2" placeholder=""></textarea> |
There was a problem hiding this comment.
All textareas share the same id (hs-pro-shwprmar). id attributes must be unique within the HTML document. Change the id for each textarea to ensure uniqueness.
For example:
<textarea id="mentor_feedback" ...>
<textarea id="content_feedback" ...>
<textarea id="assignments_feedback" ...>| <!-- Footer --> | ||
| <div class="py-4 px-6 md:px-8 border-t border-gray-200 dark:border-neutral-700"> | ||
| <div class="text-end"> | ||
| <button type="submit" class="py-2 px-3 inline-flex justify-center items-center gap-x-2 text-sm font-medium rounded-lg border border-transparent bg-blue-600 text-white hover:bg-blue-700 disabled:opacity-50 disabled:pointer-events-none focus:outline-hidden focus:bg-blue-700" data-hs-overlay="#hs-pro-shwrm"> |
There was a problem hiding this comment.
The submit button has a data-hs-overlay attribute that seems to be referencing the modal itself (#hs-pro-shwrm). Submit buttons typically don't control the modal's visibility. Remove this attribute from the submit button.
Also, the submit button should be disabled while the form is submitting to prevent multiple submissions.
| <button | ||
| x-on:click="!is_completed && (is_completed = true)" | ||
| <button data-hs-overlay="#hs-pro-shwprm" | ||
| x-on:click="if (!is_completed) { is_completed = true, showFeedback = true }" |
There was a problem hiding this comment.
Consider using a more descriptive name for the showFeedback variable to improve readability. For example, isFeedbackModalOpen might be more clear.
|
Added a new feedback form modal to collect student feedback for courses.