From 8aa65faffcceb976aab6328faabba3ffd927c83d Mon Sep 17 00:00:00 2001 From: ljosberinn Date: Tue, 23 Jun 2020 22:58:55 +0200 Subject: [PATCH 1/3] fix: attempt fixing tags postbuild --- scripts/build-client.js | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/scripts/build-client.js b/scripts/build-client.js index 90a5818d..b5a682ee 100644 --- a/scripts/build-client.js +++ b/scripts/build-client.js @@ -1,4 +1,11 @@ -const { copy, remove, readFile, writeFile, readdir } = require('fs-extra'); +const { + copy, + remove, + readFile, + writeFile, + readdir, + rename, +} = require('fs-extra'); const { resolve, join } = require('path'); const { build } = require('./build'); const { openInBrowser } = require('@parcel/utils'); @@ -63,6 +70,26 @@ async function fixWebManifest({ dest }) { ]); } +async function fixHtml({ dest }) { + const htmlContent = await readFile(join(dest, 'index.html'), 'utf8'); + + const [, ogImageName] = htmlContent.match( + //, + ); + + const replacer = new RegExp(`/${ogImageName}`, 'g'); + const newContent = htmlContent.replace( + replacer, + 'https://testing-playground.com/site.jpg', + 'utf8', + ); + + await Promise.all([ + rename(join(dest, ogImageName), join(dest, 'site.jpg')), + writeFile(join(dest, 'index.html'), newContent, 'utf8'), + ]); +} + async function main() { const dest = resolve('dist/client'); await remove(dest); @@ -80,6 +107,7 @@ async function main() { }); await fixWebManifest({ dest }); + await fixHtml({ dest }); await workbox.generateSW(workboxConfig); From ab98620dd6c6c8099fbe365896f3a43cfde0acad Mon Sep 17 00:00:00 2001 From: ljosberinn Date: Tue, 23 Jun 2020 23:10:56 +0200 Subject: [PATCH 2/3] debt: attempt to link to static image --- scripts/build-client.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/build-client.js b/scripts/build-client.js index b5a682ee..591ce107 100644 --- a/scripts/build-client.js +++ b/scripts/build-client.js @@ -77,15 +77,17 @@ async function fixHtml({ dest }) { //, ); + // temp name: /site.a47b3adf.jpg + const replacer = new RegExp(`/${ogImageName}`, 'g'); const newContent = htmlContent.replace( replacer, - 'https://testing-playground.com/site.jpg', + 'https://testing-playground.com/site.a47b3adf.jpg', 'utf8', ); await Promise.all([ - rename(join(dest, ogImageName), join(dest, 'site.jpg')), + rename(join(dest, ogImageName), join(dest, 'site.a47b3adf.jpg')), writeFile(join(dest, 'index.html'), newContent, 'utf8'), ]); } From 26ade57ab99eaae3cc88f9fbeb587db7caab7378 Mon Sep 17 00:00:00 2001 From: ljosberinn Date: Tue, 23 Jun 2020 23:18:06 +0200 Subject: [PATCH 3/3] Revert "debt: attempt to link to static image" This reverts commit ab98620dd6c6c8099fbe365896f3a43cfde0acad. --- scripts/build-client.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/scripts/build-client.js b/scripts/build-client.js index 591ce107..b5a682ee 100644 --- a/scripts/build-client.js +++ b/scripts/build-client.js @@ -77,17 +77,15 @@ async function fixHtml({ dest }) { //, ); - // temp name: /site.a47b3adf.jpg - const replacer = new RegExp(`/${ogImageName}`, 'g'); const newContent = htmlContent.replace( replacer, - 'https://testing-playground.com/site.a47b3adf.jpg', + 'https://testing-playground.com/site.jpg', 'utf8', ); await Promise.all([ - rename(join(dest, ogImageName), join(dest, 'site.a47b3adf.jpg')), + rename(join(dest, ogImageName), join(dest, 'site.jpg')), writeFile(join(dest, 'index.html'), newContent, 'utf8'), ]); }