From f2261b88f746db43d244d91102aa07b23a26f244 Mon Sep 17 00:00:00 2001 From: Nat Welch Date: Sun, 28 Sep 2025 16:35:48 -0400 Subject: [PATCH 1/4] Update required Terraform version to 1.0 Hashicorp AWS docs don't imply any required version. Decreasing this modules version requirements to match the syntax in the repo. --- versions.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/versions.tf b/versions.tf index 745d725..fa13150 100644 --- a/versions.tf +++ b/versions.tf @@ -1,5 +1,5 @@ terraform { - required_version = ">= 1.10" + required_version = ">= 1.0" required_providers { aws = { From a55dc68f93b3a358cf25a444f7a2721443ae6528 Mon Sep 17 00:00:00 2001 From: Nat Welch Date: Sun, 28 Sep 2025 20:43:39 +0000 Subject: [PATCH 2/4] fix others --- examples/complete-dns-validation-with-cloudflare/versions.tf | 2 +- examples/complete-dns-validation/versions.tf | 2 +- .../versions.tf | 2 +- examples/complete-email-validation/versions.tf | 2 +- wrappers/versions.tf | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/complete-dns-validation-with-cloudflare/versions.tf b/examples/complete-dns-validation-with-cloudflare/versions.tf index 96b2d0d..a751a62 100644 --- a/examples/complete-dns-validation-with-cloudflare/versions.tf +++ b/examples/complete-dns-validation-with-cloudflare/versions.tf @@ -1,5 +1,5 @@ terraform { - required_version = ">= 1.10" + required_version = ">= 1.0" required_providers { aws = { diff --git a/examples/complete-dns-validation/versions.tf b/examples/complete-dns-validation/versions.tf index 745d725..fa13150 100644 --- a/examples/complete-dns-validation/versions.tf +++ b/examples/complete-dns-validation/versions.tf @@ -1,5 +1,5 @@ terraform { - required_version = ">= 1.10" + required_version = ">= 1.0" required_providers { aws = { diff --git a/examples/complete-email-validation-with-validation-domain/versions.tf b/examples/complete-email-validation-with-validation-domain/versions.tf index 745d725..fa13150 100644 --- a/examples/complete-email-validation-with-validation-domain/versions.tf +++ b/examples/complete-email-validation-with-validation-domain/versions.tf @@ -1,5 +1,5 @@ terraform { - required_version = ">= 1.10" + required_version = ">= 1.0" required_providers { aws = { diff --git a/examples/complete-email-validation/versions.tf b/examples/complete-email-validation/versions.tf index 745d725..fa13150 100644 --- a/examples/complete-email-validation/versions.tf +++ b/examples/complete-email-validation/versions.tf @@ -1,5 +1,5 @@ terraform { - required_version = ">= 1.10" + required_version = ">= 1.0" required_providers { aws = { diff --git a/wrappers/versions.tf b/wrappers/versions.tf index 745d725..fa13150 100644 --- a/wrappers/versions.tf +++ b/wrappers/versions.tf @@ -1,5 +1,5 @@ terraform { - required_version = ">= 1.10" + required_version = ">= 1.0" required_providers { aws = { From 1a4308cef4ba0d4150d2f0d553f38ab4891fc78f Mon Sep 17 00:00:00 2001 From: Nat Welch Date: Sun, 28 Sep 2025 20:45:33 +0000 Subject: [PATCH 3/4] generate docs --- README.md | 2 +- examples/complete-dns-validation-with-cloudflare/README.md | 2 +- examples/complete-dns-validation/README.md | 2 +- .../complete-email-validation-with-validation-domain/README.md | 2 +- examples/complete-email-validation/README.md | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 47c1206..721d430 100644 --- a/README.md +++ b/README.md @@ -179,7 +179,7 @@ module "acm" { | Name | Version | |------|---------| -| [terraform](#requirement\_terraform) | >= 1.10 | +| [terraform](#requirement\_terraform) | >= 1.0 | | [aws](#requirement\_aws) | >= 6.4 | ## Providers diff --git a/examples/complete-dns-validation-with-cloudflare/README.md b/examples/complete-dns-validation-with-cloudflare/README.md index ff637f0..e28b7fe 100644 --- a/examples/complete-dns-validation-with-cloudflare/README.md +++ b/examples/complete-dns-validation-with-cloudflare/README.md @@ -23,7 +23,7 @@ Note that this example may create resources which cost money. Run `terraform des | Name | Version | |------|---------| -| [terraform](#requirement\_terraform) | >= 1.10 | +| [terraform](#requirement\_terraform) | >= 1.0 | | [aws](#requirement\_aws) | >= 6.4 | | [cloudflare](#requirement\_cloudflare) | >= 3.4, <=3.32 | diff --git a/examples/complete-dns-validation/README.md b/examples/complete-dns-validation/README.md index 7957c58..8cfd1c3 100644 --- a/examples/complete-dns-validation/README.md +++ b/examples/complete-dns-validation/README.md @@ -23,7 +23,7 @@ Note that this example may create resources which cost money. Run `terraform des | Name | Version | |------|---------| -| [terraform](#requirement\_terraform) | >= 1.10 | +| [terraform](#requirement\_terraform) | >= 1.0 | | [aws](#requirement\_aws) | >= 6.4 | ## Providers diff --git a/examples/complete-email-validation-with-validation-domain/README.md b/examples/complete-email-validation-with-validation-domain/README.md index dde8668..e3542ad 100644 --- a/examples/complete-email-validation-with-validation-domain/README.md +++ b/examples/complete-email-validation-with-validation-domain/README.md @@ -32,7 +32,7 @@ Note that this example may create resources which cost money. Run `terraform des | Name | Version | |------|---------| -| [terraform](#requirement\_terraform) | >= 1.10 | +| [terraform](#requirement\_terraform) | >= 1.0 | | [aws](#requirement\_aws) | >= 6.4 | ## Providers diff --git a/examples/complete-email-validation/README.md b/examples/complete-email-validation/README.md index c8a79f8..4c042c5 100644 --- a/examples/complete-email-validation/README.md +++ b/examples/complete-email-validation/README.md @@ -36,7 +36,7 @@ Note that this example may create resources which cost money. Run `terraform des | Name | Version | |------|---------| -| [terraform](#requirement\_terraform) | >= 1.10 | +| [terraform](#requirement\_terraform) | >= 1.0 | | [aws](#requirement\_aws) | >= 6.4 | ## Providers From bd4e58ef3a7b814cb82b65b48782967643aa6ae3 Mon Sep 17 00:00:00 2001 From: Nat Welch Date: Sun, 28 Sep 2025 20:54:45 +0000 Subject: [PATCH 4/4] fix cloudflare --- .../README.md | 4 ++-- .../complete-dns-validation-with-cloudflare/main.tf | 13 ------------- .../versions.tf | 9 +++------ 3 files changed, 5 insertions(+), 21 deletions(-) diff --git a/examples/complete-dns-validation-with-cloudflare/README.md b/examples/complete-dns-validation-with-cloudflare/README.md index e28b7fe..fe11afd 100644 --- a/examples/complete-dns-validation-with-cloudflare/README.md +++ b/examples/complete-dns-validation-with-cloudflare/README.md @@ -25,13 +25,13 @@ Note that this example may create resources which cost money. Run `terraform des |------|---------| | [terraform](#requirement\_terraform) | >= 1.0 | | [aws](#requirement\_aws) | >= 6.4 | -| [cloudflare](#requirement\_cloudflare) | >= 3.4, <=3.32 | +| [cloudflare](#requirement\_cloudflare) | >= 3.33.1, < 4.0.0 | ## Providers | Name | Version | |------|---------| -| [cloudflare](#provider\_cloudflare) | >= 3.4, <=3.32 | +| [cloudflare](#provider\_cloudflare) | >= 3.33.1, < 4.0.0 | ## Modules diff --git a/examples/complete-dns-validation-with-cloudflare/main.tf b/examples/complete-dns-validation-with-cloudflare/main.tf index c309692..dfcdb4e 100644 --- a/examples/complete-dns-validation-with-cloudflare/main.tf +++ b/examples/complete-dns-validation-with-cloudflare/main.tf @@ -5,22 +5,9 @@ locals { domain_name = trimsuffix(local.domain, ".") } -provider "aws" { - alias = "route53" -} - -provider "aws" { - alias = "acm" -} - module "acm" { source = "../../" - providers = { - aws.acm = aws, - aws.dns = aws - } - domain_name = local.domain_name zone_id = data.cloudflare_zone.this.id diff --git a/examples/complete-dns-validation-with-cloudflare/versions.tf b/examples/complete-dns-validation-with-cloudflare/versions.tf index a751a62..aa3116b 100644 --- a/examples/complete-dns-validation-with-cloudflare/versions.tf +++ b/examples/complete-dns-validation-with-cloudflare/versions.tf @@ -6,14 +6,11 @@ terraform { source = "hashicorp/aws" version = ">= 6.4" } - # Terraform v1.0.0 only functional with cloudflare versions less than or equal to 3.33.0 - # https://github.com/cloudflare/terraform-provider-cloudflare/issues/2340 - # Cloudflare provider version 3.33.0 introduced a regression which produced errors when - # passing credentials via environment variables - # https://github.com/cloudflare/terraform-provider-cloudflare/issues/2184 + + # Cloudflare has issues with tf 1.0 in < 3.33.1 cloudflare = { source = "cloudflare/cloudflare" - version = ">= 3.4, <=3.32" + version = ">= 3.33.1, < 4.0.0" } } }