Refactor MNIST implementation #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongtang
force-pushed
the
mnist_archive
branch
3 times, most recently
from
3bec239 to
65fb131
Compare
This fix reuses the implementation in CIFAR, reduces code duplication, and also added a couple of test cases in eager mode Signed-off-by: Yong Tang <[email protected]>
Member
Author
|
@terrytangyuan CIFAR dataset's C++ code has been reduced from 470+ lines to 130+ lines. Should help contributors to writer ops easier. |
Member
Author
|
Added in graph optimization. Dataset's implementation seems to have some trouble with Variant, so converts inputs to accept either variant, or string types. In case of python interface, variant is still used. The internal graph optimization uses serialized variant (string) now. |
Internal Graph Optimization has some trouble with Variant, so covert to String for internal graph, and maintains Variant by default. Signed-off-by: Yong Tang <[email protected]>
Merged
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
Refactor MNIST implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix reuses the implementation in CIFAR, reduces code duplication, and also added a couple of test cases in eager mode
Signed-off-by: Yong Tang [email protected]