Skip to content

Conversation

@StanislawSwierc
Copy link
Contributor

In Python 3.7 recommendation from PEP 479 was enabled. In the new
behavior StopIteration exceptions raised directly or indirectly in coroutines
and generators are transformed into RuntimeError exceptions.

https://www.python.org/dev/peps/pep-0479/

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no CLA has not been signed label Apr 25, 2019
@tfdocsbot tfdocsbot added translation Community-provided translation for certain languages tensorflow_docs labels Apr 25, 2019
@lamberta lamberta requested a review from yashk2810 April 25, 2019 18:59
@StanislawSwierc
Copy link
Contributor Author

I've just signed the Contributor License Agreement.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@yashk2810 yashk2810 removed the translation Community-provided translation for certain languages label Apr 25, 2019
@lamberta
Copy link
Member

Thanks, Stanislaw.
I looks like you signed the CLA using a different email address than the one used for this commit. Can you sign the CLA with this email or re-submit with the other?

"""
assert len(items) % 2 == 0
if not items:
return
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this instead to iter?

@MarkDaoust

zip(items[::2], items[1::2])

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much cleaner! Thx.

In Python 3.7 recommendation from PEP 479 was enabled. In the new
behavior StopIteration exceptions raised directly or indirectly in coroutines
and generators are transformed into RuntimeError exceptions.
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA has been signed and removed cla: no CLA has not been signed labels Apr 25, 2019
@MarkDaoust MarkDaoust added the ready to pull Start merge process label Apr 25, 2019
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit f064512 into tensorflow:master Apr 25, 2019
TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Apr 25, 2019
nedaresa pushed a commit to nedaresa/tensorflow-convolutional-neural-networks-optimization-key that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes CLA has been signed ready to pull Start merge process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants