-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Fix api_generator.parser._gen_pairs to work in Python 3.7 #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix api_generator.parser._gen_pairs to work in Python 3.7 #537
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I've just signed the Contributor License Agreement. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
Thanks, Stanislaw. |
| """ | ||
| assert len(items) % 2 == 0 | ||
| if not items: | ||
| return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much cleaner! Thx.
bf3f369 to
ca0d289
Compare
In Python 3.7 recommendation from PEP 479 was enabled. In the new behavior StopIteration exceptions raised directly or indirectly in coroutines and generators are transformed into RuntimeError exceptions.
ca0d289 to
f064512
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
PiperOrigin-RevId: 245308938
PiperOrigin-RevId: 245308938
In Python 3.7 recommendation from PEP 479 was enabled. In the new
behavior StopIteration exceptions raised directly or indirectly in coroutines
and generators are transformed into RuntimeError exceptions.
https://www.python.org/dev/peps/pep-0479/