Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Commit 7e35704

Browse files
authored
Merge pull request #1 from armando-fandango/rfc-move-to-addons
added some description
2 parents 9d56b3a + 0a97f6e commit 7e35704

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

rfcs/20181214-move-to-addons.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,22 +19,21 @@ invites discussion around the decisions.
1919

2020
## Motivation
2121

22-
We wish to solicit discussion regarding what tf.contrib code will be
23-
moved. Specifically, there are many contributions that are feasible to
24-
move, but we were unable to determine if there is any value in doing so.
22+
While the tensorflow repository retains core functionality along with high level frameworks such as estimators and Keras, the contributed code for additions and extensions are proposed to be moved to the repository tf.addons.
23+
24+
In this RFC, we are soliciting discussion regarding what tf.contrib code will be moved. This RFC discussion will help us determine the feasibility and value of moving the code along with the future maintainability aspects.
2525

2626
## Design Proposal
2727

2828
### Criteria for moving
2929
1) The functionality is not otherwise available in TensorFlow
30-
1) There is sufficient interested in the community to maintain it
31-
1) The code conforms to an established API pattern
32-
(Some pieces can be refactored if needed)
30+
1) There is sufficient interest in the community to maintain the code being moved
31+
1) The code conforms to an established API pattern (Some pieces can be refactored if needed)
3332

3433
It is worth noting that just because some functionality isn't part of
35-
the initial move, does not mean it won't be one day part of addons
34+
the initial move, does not mean it won't be eventually part of addons
3635
if there is value. We will begin reviewing pull requests to the
37-
repository after our initial move and directory structure is shaped.
36+
repository after the directory structure is shaped during the initial move.
3837

3938
### Code to be moved from tf.contrib to addons
4039

@@ -141,7 +140,7 @@ repository after our initial move and directory structure is shaped.
141140
| solvers | ALL | Pending community interest to maintain |
142141
| integrate | ALL | Pending community interest to maintain |
143142

144-
### Code that will not be copied from tf.contrib to addons
143+
### Code that will not be copied from tf.contrib to addons and hence would not be available in either of tf.contrib or addons
145144

146145
| Module (tf.contrib) | Class/Function | Rationale |
147146
|:----------------------- |:----------- |:------------------------------------ |
@@ -225,5 +224,6 @@ repository after our initial move and directory structure is shaped.
225224
## Questions and Discussion Topics
226225

227226
* Are there any modules being excluded from the move that you feel have substantial value to the community?
227+
* Are there any new modules that you feel should be added to addons from somewhere else apart from tf.contrib
228228
* We're actively collecting volunteers to help move, refactor and/or maintain in Addons (Please reachout to our [mailing list](https://groups.google.com/a/tensorflow.org/forum/#!forum/addons)
229-
or [gitter channel](https://gitter.im/tensorflow/sig-addons) if you have interest in helping our community.
229+
or [gitter channel](https://gitter.im/tensorflow/sig-addons) if you have interest in helping our community.

0 commit comments

Comments
 (0)