add get_config() method to TQDM_Progress_Bar #681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpmorgan
approved these changes
Nov 7, 2019
Member
seanpmorgan
left a comment
seanpmorgan
left a comment
There was a problem hiding this comment.
Thanks for the bug report @Squadrick and @shun-lin for the quick fix.
I believe SIG IO does a pip package test in their testing suite. Probably should look into that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving this issue: #679
The updated tf.keras.utils.register_keras_serializable requires get_config method, which I forgot to include in the original version. I have added the get_config method to TQDM_Progress_Bar in this PR. CC: @Squadrick