Sync custom-op #393
Merged
Sync custom-op #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Member
|
Thanks Tzu-Wei! In this PR could you pin the requirement packages to 20190731? The manylinux2010 packages are causing failing builds for us (will work on in #389) The py2 test is passing because the docker's installed pip is probably too old to install manylinux2010 packages and so it installs 20190731 |
Member
Author
|
@seanpmorgan Thanks for pointing out that, Sean :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefix of cuda include path is changed in core Tensorflow so we need to sync build files in custom-op.
Need this PR for beam_search_ops_gpu.cc and adjust_hsv_in_yiq_op_gpu.cu.cc. We could keep working on GPU kernel building after this :-)
Related links:
tensorflow/custom-op@b267cc5#diff-0c845043da8b3200ae16b7a3e1781cc2
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/util/gpu_kernel_helper.h#L22