Skip to content

Added stochastic depth layer #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 16, 2020
Merged

Added stochastic depth layer #2154

merged 13 commits into from
Sep 16, 2020

Conversation

@MHStadler
Copy link
Contributor

@MHStadler MHStadler commented Sep 8, 2020 •
edited
Loading

Description

Brief Description of the PR:

Resolves #2032

Type of change

Checklist:

  • I've properly formatted my code according to the guidelines
    • By running Black + Flake8
    • By running pre-commit hooks
  • This PR addresses an already submitted issue for TensorFlow Addons
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • This PR contains modifications to C++ custom-ops

How Has This Been Tested?

  • Unit Tests verifying the functionality
  • Unit Test verifying serialization and deserialization

@boring-cyborg boring-cyborg bot added the layers label Sep 8, 2020
@bhack
Copy link
Contributor

bhack commented Sep 8, 2020

We need a CODEOWNER for this and a co-CODEOWNER as sponsor.

@bhack bhack requested a review from WindQAQ September 8, 2020 11:54
@WindQAQ
Copy link
Member

WindQAQ commented Sep 8, 2020

I can be the co-owner, so @MHStadler feels free to list you (if you wish) and me in the .github/CODEOWNERS :-)

@boring-cyborg boring-cyborg bot added the github label Sep 8, 2020
@MHStadler
Copy link
Contributor Author

MHStadler commented Sep 8, 2020

@WindQAQ Thanks, I added us two

WindQAQ
WindQAQ reviewed Sep 9, 2020
View reviewed changes
@bhack
Copy link
Contributor

bhack commented Sep 9, 2020

Do we need mixed precision tests?

WindQAQ
WindQAQ reviewed Sep 9, 2020
View reviewed changes
@MHStadler
Copy link
Contributor Author

MHStadler commented Sep 9, 2020

@bhack I looked at some of the existing mixed_precision tests, and I added one to check the output dtype is retained correctly

Let me know if and which further tests I should add

WindQAQ
WindQAQ reviewed Sep 10, 2020
View reviewed changes
WindQAQ
WindQAQ reviewed Sep 14, 2020
View reviewed changes
@WindQAQ WindQAQ self-requested a review September 16, 2020 23:50
WindQAQ
WindQAQ approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@WindQAQ WindQAQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@WindQAQ WindQAQ merged commit dbcd5aa into tensorflow:master Sep 16, 2020
@bot-of-gabrieldemarmiesse bot-of-gabrieldemarmiesse mentioned this pull request Sep 29, 2020
Merged
jrruijli pushed a commit to jrruijli/addons that referenced this pull request Dec 23, 2020
@MHStadler
Added stochastic depth layer (tensorflow#2154)
07ef1a1 
* Added stochastic depth layer

* Fixed code style and added missing __init__ entry

* Fixed tests and style

* Fixed code style

* Updated CODEOWNERS

* Added codeowners for tests

* Changes after code review

* Test and formatting fixes

* Fixed doc string

* Added mixed precision test

* Further code review changes

* Code review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WindQAQ WindQAQ WindQAQ approved these changes

@facaiy facaiy Awaiting requested review from facaiy

@seanpmorgan seanpmorgan Awaiting requested review from seanpmorgan

Assignees

No one assigned

Labels

backport r0.11 cla: yes github layers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request : Stochastic Depth/ResDrop

5 participants

@MHStadler @bhack @WindQAQ @googlebot @seanpmorgan