Skip to content

Commit fa4771d

Browse files
Squadrickseanpmorgan
authored andcommitted
Don't build parse_time till TF r2.1 (#710)
* Don't build parse_time till TF r2.1 * Fix TODO, and BUILD * Remove .py file from build target
1 parent 987f455 commit fa4771d

File tree

3 files changed

+26
-22
lines changed

3 files changed

+26
-22
lines changed

tensorflow_addons/custom_ops/text/BUILD

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,11 @@ custom_op_library(
1212
],
1313
)
1414

15-
custom_op_library(
16-
name = "_parse_time_op.so",
17-
srcs = [
18-
"cc/kernels/parse_time_kernel.cc",
19-
"cc/ops/parse_time_op.cc",
20-
],
21-
)
15+
# TODO: https://github.com/tensorflow/addons/issues/663
16+
# custom_op_library(
17+
# name = "_parse_time_op.so",
18+
# srcs = [
19+
# "cc/kernels/parse_time_kernel.cc",
20+
# "cc/ops/parse_time_op.cc",
21+
# ],
22+
# )

tensorflow_addons/text/BUILD

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,17 @@ licenses(["notice"]) # Apache 2.0
22

33
package(default_visibility = ["//visibility:public"])
44

5+
# TODO: https://github.com/tensorflow/addons/issues/663
56
py_library(
67
name = "text",
78
srcs = ([
89
"__init__.py",
910
"crf.py",
10-
"parse_time_op.py",
11+
# "parse_time_op.py",
1112
"skip_gram_ops.py",
1213
]),
1314
data = [
14-
"//tensorflow_addons/custom_ops/text:_parse_time_op.so",
15+
# "//tensorflow_addons/custom_ops/text:_parse_time_op.so",
1516
"//tensorflow_addons/custom_ops/text:_skip_gram_ops.so",
1617
"//tensorflow_addons/utils",
1718
],
@@ -44,15 +45,16 @@ py_test(
4445
],
4546
)
4647

47-
py_test(
48-
name = "parse_time_op_test",
49-
size = "small",
50-
srcs = [
51-
"parse_time_op_test.py",
52-
],
53-
main = "parse_time_op_test.py",
54-
srcs_version = "PY2AND3",
55-
deps = [
56-
":text",
57-
],
58-
)
48+
# TODO: https://github.com/tensorflow/addons/issues/663
49+
# py_test(
50+
# name = "parse_time_op_test",
51+
# size = "small",
52+
# srcs = [
53+
# "parse_time_op_test.py",
54+
# ],
55+
# main = "parse_time_op_test.py",
56+
# srcs_version = "PY2AND3",
57+
# deps = [
58+
# ":text",
59+
# ],
60+
# )

tensorflow_addons/text/__init__.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,6 @@
3434
from tensorflow_addons.text.skip_gram_ops import skip_gram_sample
3535
from tensorflow_addons.text.skip_gram_ops import skip_gram_sample_with_text_vocab
3636

37+
# TODO: https://github.com/tensorflow/addons/issues/663
3738
# Parse Time
38-
from tensorflow_addons.text.parse_time_op import parse_time
39+
# from tensorflow_addons.text.parse_time_op import parse_time

0 commit comments

Comments
 (0)