Merge branch 'master' into philjd/decaoupled_weight_decay

Author: PhilJd

.github/CODEOWNERS

@@ -3,11 +3,19 @@
 # SIG maintainers are the catch all for reviews
 * @tensorflow/sig-addons-maintainers
 
-
 # Subpackage Owners
+/tensorflow_addons/activations/ @facaiy @seanpmorgan
+/tensorflow_addons/image/ @windqaq @facaiy 
+/tensorflow_addons/layers/ @seanpmorgan @facaiy
+/tensorflow_addons/losses/ @facaiy @windqaq
+/tensorflow_addons/optimizers/ @facaiy @windqaq
+/tensorflow_addons/rnn/ @qlzh727
 /tensorflow_addons/seq2seq/ @qlzh727
-/tensorflow_addons/custom_ops/seq2seq/ @qlzh727
+/tensorflow_addons/text/ @seanpmorgan @facaiy
 
+/tensorflow_addons/custom_ops/image/ @windqaq @facaiy
+/tensorflow_addons/custom_ops/seq2seq/ @qlzh727
+/tensorflow_addons/custom_ops/text/ @seanpmorgan @facaiy
 
 # Submodule Owners
 # These may not automatically trigger a review because submodule owners do not
@@ -17,7 +25,7 @@
 /tensorflow_addons/activations/sparsemax*.py @AndreasMadsen
 /tensorflow_addons/image/dense_image_warp*.py @WindQAQ
 /tensorflow_addons/image/distort_image_ops*.py @WindQAQ
-/tensorflow_addons/image/median_filter_2d*.py @Mainak431
+/tensorflow_addons/image/filters*.py @Mainak431
 /tensorflow_addons/layers/normalizations*.py @smokrow
 /tensorflow_addons/layers/sparsemax*.py @AndreasMadsen
 /tensorflow_addons/losses/contrastive*.py @WindQAQ

.gitignore

@@ -30,6 +30,7 @@ wheels/
 # IDE
 .vscode/
 .idea/
+*.iml
 
 # Build
 /.bazelrc

BUILD

@@ -11,6 +11,7 @@ sh_binary(
         "//tensorflow_addons/layers",
         "//tensorflow_addons/losses",
         "//tensorflow_addons/optimizers",
+        "//tensorflow_addons/rnn",
         "//tensorflow_addons/seq2seq",
         "//tensorflow_addons/text",
     ],

README.md

@@ -29,13 +29,14 @@ developments that cannot be integrated into core TensorFlow
 ## Maintainers
 | Subpackage    | Maintainers  | Contact Info                        |
 |:----------------------- |:----------- |:----------------------------|
-| [tfa.activations](tensorflow_addons/activations/README.md) | SIG-Addons | [email protected]    |
-| [tfa.image](tensorflow_addons/image/README.md) |  |                                   |
-| [tfa.layers](tensorflow_addons/layers/README.md) | SIG-Addons |     [email protected] |
-| [tfa.losses](tensorflow_addons/losses/README.md) | SIG-Addons |     [email protected] |
-| [tfa.optimizers](tensorflow_addons/optimizers/README.md) | SIG-Addons | [email protected] |
-| [tfa.seq2seq](tensorflow_addons/seq2seq/README.md) | Google | @qlzh727 | 
-| [tfa.text](tensorflow_addons/text/README.md) |  |  |
+| [tfa.activations](tensorflow_addons/activations/README.md) | SIG-Addons | @facaiy @seanpmorgan | 
+| [tfa.image](tensorflow_addons/image/README.md) | SIG-Addons | @windqaq @facaiy |
+| [tfa.layers](tensorflow_addons/layers/README.md) | SIG-Addons | @seanpmorgan @facaiy |
+| [tfa.losses](tensorflow_addons/losses/README.md) | SIG-Addons | @facaiy @windqaq   |
+| [tfa.optimizers](tensorflow_addons/optimizers/README.md) | SIG-Addons | @facaiy @windqaq |
+| [tfa.rnn](tensorflow_addons/rnn/README.md) | Google | @qlzh727 |
+| [tfa.seq2seq](tensorflow_addons/seq2seq/README.md) | Google | @qlzh727 |
+| [tfa.text](tensorflow_addons/text/README.md) |  SIG-Addons |  @seanpmorgan @facaiy |
 
 ## Core Concepts
 
@@ -61,8 +62,8 @@ To install the latest version, run the following:
 ```
 pip install tensorflow-addons
 ```
-
-**Note:** You will also need [TensorFlow 2.0 or higher](https://www.tensorflow.org/alpha). 
+ 
+**Note:** You will also need [`tensorflow==2.0.0.a0`](https://www.tensorflow.org/alpha) installed.
 
 To use addons:
 
@@ -75,6 +76,8 @@ import tensorflow_addons as tfa
 You can also install from source. This requires the [Bazel](
 https://bazel.build/) build system.
 
+**Note:** If building from master you must install `tf-nightly-2.0-preview` in the process.
+
 ```
 git clone https://github.com/tensorflow/addons.git
 cd addons
@@ -88,8 +91,6 @@ bazel-bin/build_pip_pkg artifacts
 pip install artifacts/tensorflow_addons-*.whl
 ```
 
-**Notice**: If you are using Mac OS X, you need install addition software by `brew install coreutils` (this requires the [Homebrew](https://brew.sh/)) or `port install coreutils` (this requires the [MacPorts](https://www.macports.org/))
-
 ## Contributing
 TF-Addons is a community led open source project. As such, the project
 depends on public contributions, bug-fixes, and documentation. Please

STYLE_GUIDE.md

@@ -37,4 +37,9 @@ BAR = [
 # pylint: disable=protected-access
 foo._protected_member
 # pylint: enable=protected-access
-```
+```
+
+
+#### TensorFlow Conventions
+
+Follow the guidance in the [TensorFlow Style Guide - Conventions](https://www.tensorflow.org/community/contribute/code_style#tensorflow_conventions_and_special_uses).

build_pip_pkg.sh

@@ -16,44 +16,27 @@
 set -e
 set -x
 
-PLATFORM="$(uname -s | tr 'A-Z' 'a-z')"
-
 PIP_FILE_PREFIX="bazel-bin/build_pip_pkg.runfiles/__main__/"
 
-if [[ ${PLATFORM} == "darwin" ]]; then
-    READLINK="greadlink"  # from pkg `coreutils` in brew/macports in Mac OS X
-else
-    READLINK="readlink"
-fi
-
+function abspath() {
+  cd "$(dirname $1)"
+  echo "$PWD/$(basename $1)"
+  cd "$OLDPWD"
+}
 
 function main() {
-  while [[ ! -z "${1}" ]]; do
-    if [[ ${1} == "make" ]]; then
-      echo "Using Makefile to build pip package."
-      PIP_FILE_PREFIX=""
-    else
-      DEST=${1}
-    fi
-    shift
-  done
-
+  DEST=${1}
   if [[ -z ${DEST} ]]; then
     echo "No destination dir provided"
     exit 1
   fi
 
-  # Create the directory, then do dirname on a non-existent file inside it to
-  # give us an absolute paths with tilde characters resolved to the destination
-  # directory.
   mkdir -p ${DEST}
-  DEST=$(${READLINK} -f "${DEST}")
+  DEST=$(abspath "${DEST}")
   echo "=== destination directory: ${DEST}"
 
   TMPDIR=$(mktemp -d -t tmp.XXXXXXXXXX)
-
   echo $(date) : "=== Using tmpdir: ${TMPDIR}"
-
   echo "=== Copy TensorFlow Addons files"
 
   cp ${PIP_FILE_PREFIX}setup.py "${TMPDIR}"

configure.sh

@@ -35,10 +35,17 @@ function write_action_env_to_bazelrc() {
 }
 
 [[ -f .bazelrc ]] && rm .bazelrc
+read -r -p "Tensorflow will be upgraded to 2.0. Are You Sure? [Y/n] " reply
+case $reply in
+    [yY]*) echo "Installing...";;
+    * ) echo "Goodbye!"; exit;;
+esac
 pip install $QUIET_FLAG -r requirements.txt
 
 TF_CFLAGS=( $(python -c 'import tensorflow as tf; print(" ".join(tf.sysconfig.get_compile_flags()))') )
 TF_LFLAGS=( $(python -c 'import tensorflow as tf; print(" ".join(tf.sysconfig.get_link_flags()))') )
+TF_SHAREDLIB=( $(python -c 'import tensorflow as tf; print(tf.sysconfig.get_link_flags()[-1])') )
 
 write_action_env_to_bazelrc "TF_HEADER_DIR" ${TF_CFLAGS:2}
 write_action_env_to_bazelrc "TF_SHARED_LIBRARY_DIR" ${TF_LFLAGS:2}
+write_action_env_to_bazelrc "TF_SHARED_LIBRARY_NAME" ${TF_SHAREDLIB:3}

tensorflow_addons/__init__.py

@@ -76,6 +76,7 @@ def _ensure_tf_install():
 from tensorflow_addons import layers
 from tensorflow_addons import losses
 from tensorflow_addons import optimizers
+from tensorflow_addons import rnn
 from tensorflow_addons import seq2seq
 from tensorflow_addons import text
 

tensorflow_addons/custom_ops/__init__.py

@@ -52,7 +52,7 @@ class EuclideanDistanceTransformGenerator {
 
     if (input_(coords) == T(0)) return T(0);
 
-    float minDistance = std::numeric_limits<T>::max();
+    float minDistance = static_cast<float>(std::numeric_limits<T>::max());
 
     for (int h = 0; h < height_; ++h) {
       for (int w = 0; w < width_; ++w) {