Merge branch 'master' into doctest

Author: autoih

.flake8

@@ -27,12 +27,5 @@ per-file-ignores =
     tensorflow_addons/image/tests/utils_test.py:N802
     tensorflow_addons/image/tests/color_ops_test.py:N802
     tensorflow_addons/optimizers/tests/conditional_gradient_test.py:N802
-    tensorflow_addons/optimizers/tests/lazy_adam_test.py:N802
-    tensorflow_addons/seq2seq/tests/attention_wrapper_test.py:N802
-    tensorflow_addons/seq2seq/tests/basic_decoder_test.py:N802
-    tensorflow_addons/seq2seq/tests/decoder_test.py:N802
-    tensorflow_addons/seq2seq/tests/beam_search_decoder_test.py:N802
-    tensorflow_addons/seq2seq/tests/beam_search_ops_test.py:N802
-    tensorflow_addons/optimizers/tests/cyclical_learning_rate_test.py:N802
     # variable ... in function should be lowercase
     tensorflow_addons/callbacks/tests/time_stopping_test.py:N806

.github/CODEOWNERS

@@ -58,8 +58,8 @@
 /tensorflow_addons/image/tests/distance_transform_test.py @mels630
 /tensorflow_addons/image/distort_image_ops.py @windqaq
 /tensorflow_addons/image/tests/distort_image_ops_test.py @windqaq
-/tensorflow_addons/image/filters.py @mainak431
-/tensorflow_addons/image/tests/filters_test.py @mainak431
+/tensorflow_addons/image/filters.py @mainak431 @ghosalsattam
+/tensorflow_addons/image/tests/filters_test.py @mainak431 @ghosalsattam
 /tensorflow_addons/image/interpolate_spline.py
 /tensorflow_addons/image/tests/interpolate_spline_test.py
 /tensorflow_addons/image/resampler_ops.py @autoih

.github/workflows/backport.yml

@@ -12,7 +12,7 @@ jobs:
     steps:
       - name: Backport Bot
         if: github.event.pull_request.merged && ( ( github.event.action == 'closed' && contains( join( github.event.pull_request.labels.*.name ), 'backport') ) || contains( github.event.label.name, 'backport' ) )
-        uses: Gaurav0/backport@v1.0.24
+        uses: Gaurav0/backport@d69fd1d # Version 1.0.24
         with:
           bot_username: bot-of-gabrieldemarmiesse
           bot_token: 1353d990cdb8b8ceb1b73d301dce83cc0da3db29

.github/workflows/ci_test.yml

@@ -70,12 +70,6 @@ jobs:
       - uses: actions/checkout@v2
       - name: Building the docs
         run: bash tools/run_build.sh docs_tests
-  test_editable_mode:
-    name: Check that we can fully work in editable mode
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      - run: bash tools/run_build.sh test_editable_mode
   test_python_code_only:
     name: Fast build to run python-only tests
     runs-on: ubuntu-latest
@@ -93,19 +87,6 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - run: bash tools/run_cpu_tests.sh
-  test_tf220rc3_cpu_in_small_docker_image:
-    name: Run the tf 2.2.0rc3 cpu tests in a small python docker image
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-      - env:
-          DOCKER_BUILDKIT: 1
-        run: |
-          docker build \
-              --build-arg TF_VERSION=2.2.0rc3 \
-              -f tools/docker/cpu_tests.Dockerfile \
-              --target=build_wheel \
-              ./
   valid-codeowners:
     name: Check that the CODEOWNERS is valid
     runs-on: ubuntu-latest

.github/workflows/make_wheel_Windows.sh

@@ -4,11 +4,9 @@ export TF_NEED_CUDA=0
 export BAZEL_VC="C:/Program Files (x86)/Microsoft Visual Studio/2019/Enterprise/VC/"
 
 python -m pip install wheel setuptools tensorflow==$TF_VERSION
-curl -sSOL https://github.com/bazelbuild/bazel/releases/download/${BAZEL_VERSION}/bazel-${BAZEL_VERSION}-windows-x86_64.exe
-export BAZEL_PATH=/d/a/addons/addons/bazel-${BAZEL_VERSION}-windows-x86_64.exe
 bash ./tools/testing/build_and_run_tests.sh
 
-./bazel-${BAZEL_VERSION}-windows-x86_64.exe build \
+bazel.exe build \
   -c opt \
   --enable_runfiles \
   --noshow_progress \

.github/workflows/make_wheel_macOS.sh

@@ -5,7 +5,6 @@ export TF_NEED_CUDA=0
 python --version
 python -m pip install delocate wheel setuptools tensorflow==$TF_VERSION
 
-bash tools/install_deps/bazel_macos.sh $BAZEL_VERSION
 bash tools/testing/build_and_run_tests.sh
 
 bazel build \

.github/workflows/release-drafter.yml

@@ -10,7 +10,7 @@ jobs:
   update_release_draft:
     runs-on: ubuntu-latest
     steps:
-      - uses: release-drafter/release-drafter@v5
+      - uses: release-drafter/release-drafter@74e7c42 # Version 5.7.0
         with:
           config-name: release-template.yml
         env:

.github/workflows/release.yml

@@ -15,7 +15,7 @@ on:
       - r*
 
 env:
-  BAZEL_VERSION: 1.1.0
+  BAZEL_VERSION: '1.1.0'
   MIN_PY_VERSION: '3.5'
   MAX_PY_VERSION: '3.8'
 
@@ -41,7 +41,7 @@ jobs:
       matrix:
         os: ['macos-latest', 'windows-latest', 'ubuntu-18.04']
         py-version: ['3.5', '3.6', '3.7', '3.8']
-        tf-version: ['2.1.0', '2.2.0rc3']
+        tf-version: ['2.2.0rc4']
       fail-fast: false
     steps:
       - uses: actions/[email protected]
@@ -57,10 +57,15 @@ jobs:
       - uses: actions/setup-python@v1
         with:
           python-version: ${{ matrix.py-version }}
+      - name: Setup Bazel
+        # Ubuntu bazel is run inside of the docker image
+        if: matrix.os != 'ubuntu-18.04'
+        # MacOS VMs share IP addr on GH actions. This bazel installation authenticates token to prevent api rate limiting.
+        uses: jwlawson/actions-setup-bazel@784af34 # Version 1.1
+        with:
+          bazel-version: ${{ env.BAZEL_VERSION}}
+          github-api-token: ${{ secrets.GITHUB_TOKEN }}
       - name: Build wheels
-        if: |
-          (matrix.py-version != '3.8' || matrix.tf-version != '2.1.0')
-          && (github.event_name != 'pull_request' || matrix.py-version == env.MIN_PY_VERSION || matrix.py-version == env.MAX_PY_VERSION)
         env:
           OS: ${{ runner.os }}
           PY_VERSION: ${{ matrix.py-version }}
@@ -69,9 +74,6 @@ jobs:
         shell: bash
         run: bash .github/workflows/make_wheel_${OS}.sh
       - uses: actions/upload-artifact@v1
-        if: |
-          (matrix.py-version != '3.8' || matrix.tf-version != '2.1.0')
-          && (github.event_name != 'pull_request' || matrix.py-version == env.MIN_PY_VERSION || matrix.py-version == env.MAX_PY_VERSION)
         with:
           name: ${{ runner.os }}-${{ matrix.py-version }}-tf${{ matrix.tf-version }}-wheel
           path: wheelhouse
@@ -82,16 +84,15 @@ jobs:
     strategy:
       matrix:
         os: ['macOS', 'Windows', 'Linux']
-        py-version: ['3.5', '3.6', '3.7']
+        py-version: ['3.5', '3.6', '3.7', '3.8']
+        tf-version: ['2.2.0rc4']
       fail-fast: false
     steps:
       - uses: actions/download-artifact@v1
-        if: github.event_name != 'pull_request' || matrix.py-version == env.MIN_PY_VERSION  || matrix.py-version == env.MAX_PY_VERSION
         with:
-          name: ${{ matrix.os }}-${{ matrix.py-version }}-tf2.1.0-wheel
+          name: ${{ matrix.os }}-${{ matrix.py-version }}-tf${{ matrix.tf-version }}-wheel
           path: ./dist
-      - if: github.event_name != 'pull_request' || matrix.py-version == env.MIN_PY_VERSION  || matrix.py-version == env.MAX_PY_VERSION
-        run: |
+      - run: |
           set -e -x
           ls -la dist/
           sha256sum dist/*.whl

.gitignore

@@ -23,6 +23,7 @@ wheels/
 *.egg-info/
 .installed.cfg
 *.egg
+pip-wheel-metadata
 
 # Jupyter Notebook
 .ipynb_checkpoints

CONTRIBUTING.md

@@ -160,6 +160,8 @@ conda activate my_dev_environement
 Just run from the root:
 
 ```
+pip install tensorflow==2.2.0rc4
+# you can use "pip install tensorflow-cpu==2.2.0rc4" too if you're not testing on gpu.
 pip install -e ./
 ```
 
@@ -247,7 +249,7 @@ If you need a custom C++/Cuda op for your test, compile your ops with
 
 ```bash
 python configure.py
-pip install tensorflow==2.1.0 -e ./ -r tools/install_deps/pytest.txt
+pip install tensorflow==2.2.0rc4 -e ./ -r tools/install_deps/pytest.txt
 bash tools/install_so_files.sh  # Linux/macos/WSL2
 sh tools/install_so_files.sh    # PowerShell
 ```
@@ -275,14 +277,14 @@ docker run --runtime=nvidia --rm -it -v ${PWD}:/addons -w /addons tensorflow/ten
 
 Configure:
 ```
-python3 -m pip install tensorflow==2.1.0
+python3 -m pip install tensorflow==2.2.0rc4
 python3 ./configure.py  # Links project with TensorFlow dependency
 ```
 
 Install in editable mode
 ```
 python3 -m pip install -e .
-python3 -m pip install pytest pytest-xdist
+python3 -m pip install -r tools/install_deps/pytest.txt
 ```
 
 Compile the custom ops
@@ -295,6 +297,10 @@ Run selected tests:
 python3 -m pytest path/to/file/or/directory/to/test
 ```
 
+Run the gpu only tests with `pytest -m needs_gpu ./tensorflow_addons`.
+Run the cpu only tests with `pytest -m 'not needs_gpu' ./tensorflow_addons`.
+
+
 #### Testing with Bazel
 
 Testing with Bazel is still supported but not recommended unless you have prior experience 
@@ -309,9 +315,9 @@ quickly, as Bazel has great support for caching and distributed testing.
 To test with Bazel:
 
 ```
-python3 -m pip install tensorflow==2.1.0
+python3 -m pip install tensorflow==2.2.0rc4
 python3 configure.py
-python3 -m pip install pytest
+python3 -m pip install -r tools/install_deps/pytest.txt
 bazel test -c opt -k \
 --test_timeout 300,450,1200,3600 \
 --test_output=all \
@@ -409,22 +415,46 @@ on Tensors, `if` or `for` for example. Or with `TensorArray`. In short, when the
  conversion to graph is not trivial. No need to use it on all
 your tests. Having fast tests is important.
 
-#### cpu_and_gpu
+#### Selecting the devices to run the test
+
+By default, each test is wrapped behind the scenes with a 
+```python
+with tf.device("CPU:0"):
+    ...
+```
 
-Will run your test function twice, once with `with tf.device("/device:CPU:0")` and 
-once with `with tf.device("/device:GPU:0")`. If a GPU is not present on the system, 
-the second test is skipped. To use it:
+This is automatic. But it's also possible to ask the test runner to run 
+the test twice, on CPU and on GPU, or only on GPU. Here is how to do it.
 
 ```python
-@pytest.mark.usefixtures("cpu_and_gpu")
+import pytest
+
+@pytest.mark.with_device(["cpu", "gpu"])
 def test_something():
-    assert ...== ...
+    # the code here will run twice, once on gpu, once on cpu.
+    ...
+
+@pytest.mark.with_device(["gpu"])
+def test_something_else():
+    # This test will be only run on gpu.
+    # The test runner will call with tf.device("GPU:0") behind the scenes.  
+    ...
+
+@pytest.mark.with_device(["cpu"])
+def test_something_more():
+    # Don't do that, this is the default behavior. 
+    ...
 ```
 
+Note that if a gpu is not detected on the system, the test will be 
+skipped and not marked as failed. Only the first gpu of the system is used,
+even when running pytest in multiprocessing mode. (`-n` argument). 
+Beware of the out of cuda memory errors if the number of pytest workers is too high.
+
 ##### When to use it?
 
-When you test custom CUDA code. We can expect existing TensorFlow ops to behave the same 
-on CPU and GPU.
+When you test custom CUDA code or float16 ops.
+We can expect other existing TensorFlow ops to behave the same on CPU and GPU.
 
 #### data_format