From a7094a236f62edd430709d04baa7b829a3c5750b Mon Sep 17 00:00:00 2001 From: Technote Date: Tue, 3 Mar 2020 21:15:29 +0900 Subject: [PATCH 1/2] chore: tweaks --- __tests__/misc.test.ts | 17 +++++++++++++---- src/index.ts | 2 +- src/misc.ts | 4 ++-- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/__tests__/misc.test.ts b/__tests__/misc.test.ts index 42cc9bc..e7c9994 100644 --- a/__tests__/misc.test.ts +++ b/__tests__/misc.test.ts @@ -62,10 +62,19 @@ describe('getContext', () => { describe('getContextArgs', () => { testEnv(); - it('should throw', async() => { + it('should throw 1', async() => { process.env.INPUT_GITHUB_TOKEN = 'token'; - await expect(getContextArgs(getGitHelper(), undefined, 'release/v1.2.3', '', { + await expect(getContextArgs(getGitHelper(), undefined, 'release/v1.2.3', '', undefined, { + owner: 'test-owner', + repo: 'test-repo', + })).rejects.toThrow(' is required.'); + }); + + it('should throw 2', async() => { + process.env.INPUT_GITHUB_TOKEN = 'token'; + + await expect(getContextArgs(getGitHelper(), undefined, 'release/v1.2.3', '', true, { owner: 'test-owner', repo: 'test-repo', })).rejects.toThrow(' is required.'); @@ -74,7 +83,7 @@ describe('getContextArgs', () => { it('should get context args 1', async() => { process.env.INPUT_GITHUB_TOKEN = 'token'; - expect(await getContextArgs(getGitHelper(), 'v1.2.3', 'release/v1.2.3', '', { + expect(await getContextArgs(getGitHelper(), 'v1.2.3', 'release/v1.2.3', '', false, { owner: 'test-owner', repo: 'test-repo', })).toEqual({ @@ -97,7 +106,7 @@ describe('getContextArgs', () => { }, }); - expect(await getContextArgs(getGitHelper(), '', 'release/v1.2.3', '', { + expect(await getContextArgs(getGitHelper(), '', 'release/v1.2.3', '', true, { owner: 'test-owner', repo: 'test-repo', inputs: { diff --git a/src/index.ts b/src/index.ts index 85ece0a..d169465 100644 --- a/src/index.ts +++ b/src/index.ts @@ -24,7 +24,7 @@ export const execute = async(): Promise => { process.env.INPUT_GITHUB_TOKEN = token; const helper = getGitHelper(); const config = getConfig(commander.package, commander.test); - const args = await getContextArgs(helper, commander.tag, commander.branch, commander.package, config); + const args = await getContextArgs(helper, commander.tag, commander.branch, commander.package, commander.test, config); setEnv(config, commander.workspace); if (!isValidContext(args)) { diff --git a/src/misc.ts b/src/misc.ts index a91025a..05201c5 100644 --- a/src/misc.ts +++ b/src/misc.ts @@ -22,9 +22,9 @@ export const getRepository = (dir: string): { owner: string; repo: string } | ne }; }; -export const getContextArgs = async(helper: GitHelper, tagName: string | undefined, branch: string | undefined, dir: string, config: Config): Promise => { +export const getContextArgs = async(helper: GitHelper, tagName: string | undefined, branch: string | undefined, dir: string, isTest: boolean | undefined, config: Config): Promise => { if (!tagName) { - if (!config.inputs?.TEST_TAG_PREFIX) { + if (!isTest || !config.inputs?.TEST_TAG_PREFIX) { throw new Error(' is required.'); } From 08d5def3f1cdd709bd320c245f9b343ce1da0bcf Mon Sep 17 00:00:00 2001 From: Technote Date: Tue, 3 Mar 2020 21:17:32 +0900 Subject: [PATCH 2/2] feat: update package version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 5b1333c..ab8f0b7 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@technote-space/release-github-actions-cli", - "version": "1.4.0", + "version": "1.4.1", "description": "Release GitHub Actions Cli", "author": { "name": "Technote",