-
Notifications
You must be signed in to change notification settings - Fork 47
wip: Generate UVs for polylines and polygons #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Build is failing because of new API usage for network IO. Depends on #57 . |
@karimnaaji you can rebase the PR now. |
449a70f
to
50cc6c4
Compare
50cc6c4
to
3bdeaa1
Compare
matteblair
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polygon and polyline builder now have different extrusion option: top, top and sides, sides, none. This gives enough granularity at the filter level in order to assign materials to different part of a polygon (for example generating a building with a material associated with its wall faces and a different one for the top). In the current PR the material is at the layer filter level, after testing this for a bit it appears more natural to selectively apply material at the builder extrusion option level, so a material could directly be applied without too much work while authoring the filters, this part is subject for change.
Polylines have their UVs continuing between different part of the polyline, and are stretched based on the polyline width. This covers some straight use cases like applying a repeating pattern to road networks:
This PR supersedes #56 .
TODO: