Stimulus: move deprecations from DTOs to filters/functions

Author: jmsche

src/Dto/StimulusActionsDto.php

@@ -32,7 +32,6 @@ public function addAction($dataOrControllerName, string $actionName = null, stri
         if (\is_string($dataOrControllerName)) {
             $data = [$dataOrControllerName => null === $eventName ? [[$actionName]] : [[$eventName => $actionName]]];
         } else {
-            trigger_deprecation('symfony/webpack-encore-bundle', 'v1.15.0', 'Passing an array as first argument of stimulus_action() is deprecated.');
             if ($actionName || $eventName || $parameters) {
                 throw new \InvalidArgumentException('You cannot pass a string to the second or third argument nor an array to the fourth argument while passing an array to the first argument of stimulus_action(): check the documentation.');
             }

src/Dto/StimulusControllersDto.php

@@ -30,7 +30,6 @@ public function addController($dataOrControllerName, array $controllerValues = [
         if (\is_string($dataOrControllerName)) {
             $data = [$dataOrControllerName => $controllerValues];
         } else {
-            trigger_deprecation('symfony/webpack-encore-bundle', 'v1.15.0', 'Passing an array as first argument of stimulus_controller() is deprecated.');
             if ($controllerValues) {
                 throw new \InvalidArgumentException('You cannot pass an array to the first and second argument of stimulus_controller(): check the documentation.');
             }

src/Dto/StimulusTargetsDto.php

@@ -29,7 +29,6 @@ public function addTarget($dataOrControllerName, string $targetNames = null): vo
         if (\is_string($dataOrControllerName)) {
             $data = [$dataOrControllerName => $targetNames];
         } else {
-            trigger_deprecation('symfony/webpack-encore-bundle', 'v1.15.0', 'Passing an array as first argument of stimulus_target() is deprecated.');
             if ($targetNames) {
                 throw new \InvalidArgumentException('You cannot pass a string to the second argument while passing an array to the first argument of stimulus_target(): check the documentation.');
             }

src/Twig/StimulusTwigExtension.php

@@ -48,6 +48,10 @@ public function getFilters(): array
      */
     public function renderStimulusController(Environment $env, $dataOrControllerName, array $controllerValues = []): StimulusControllersDto
     {
+        if (!\is_string($dataOrControllerName)) {
+            trigger_deprecation('symfony/webpack-encore-bundle', 'v1.15.0', 'Passing an array as first argument of stimulus_controller() is deprecated.');
+        }
+
         $dto = new StimulusControllersDto($env);
         $dto->addController($dataOrControllerName, $controllerValues);
 
@@ -65,6 +69,10 @@ public function renderStimulusController(Environment $env, $dataOrControllerName
      */
     public function appendStimulusController(StimulusControllersDto $dto, $dataOrControllerName, array $controllerValues = []): StimulusControllersDto
     {
+        if (!\is_string($dataOrControllerName)) {
+            trigger_deprecation('symfony/webpack-encore-bundle', 'v1.15.0', 'Passing an array as first argument of stimulus_controller() is deprecated.');
+        }
+
         $dto->addController($dataOrControllerName, $controllerValues);
 
         return $dto;
@@ -83,6 +91,10 @@ public function appendStimulusController(StimulusControllersDto $dto, $dataOrCon
      */
     public function renderStimulusAction(Environment $env, $dataOrControllerName, string $actionName = null, string $eventName = null, array $parameters = []): StimulusActionsDto
     {
+        if (!\is_string($dataOrControllerName)) {
+            trigger_deprecation('symfony/webpack-encore-bundle', 'v1.15.0', 'Passing an array as first argument of stimulus_action() is deprecated.');
+        }
+
         $dto = new StimulusActionsDto($env);
         $dto->addAction($dataOrControllerName, $actionName, $eventName, $parameters);
 
@@ -102,6 +114,10 @@ public function renderStimulusAction(Environment $env, $dataOrControllerName, st
      */
     public function appendStimulusAction(StimulusActionsDto $dto, $dataOrControllerName, string $actionName = null, string $eventName = null, array $parameters = []): StimulusActionsDto
     {
+        if (!\is_string($dataOrControllerName)) {
+            trigger_deprecation('symfony/webpack-encore-bundle', 'v1.15.0', 'Passing an array as first argument of stimulus_action() is deprecated.');
+        }
+
         $dto->addAction($dataOrControllerName, $actionName, $eventName, $parameters);
 
         return $dto;
@@ -118,6 +134,10 @@ public function appendStimulusAction(StimulusActionsDto $dto, $dataOrControllerN
      */
     public function renderStimulusTarget(Environment $env, $dataOrControllerName, string $targetNames = null): StimulusTargetsDto
     {
+        if (!\is_string($dataOrControllerName)) {
+            trigger_deprecation('symfony/webpack-encore-bundle', 'v1.15.0', 'Passing an array as first argument of stimulus_target() is deprecated.');
+        }
+
         $dto = new StimulusTargetsDto($env);
         $dto->addTarget($dataOrControllerName, $targetNames);
 
@@ -135,6 +155,10 @@ public function renderStimulusTarget(Environment $env, $dataOrControllerName, st
      */
     public function appendStimulusTarget(StimulusTargetsDto $dto, $dataOrControllerName, string $targetNames = null): StimulusTargetsDto
     {
+        if (!\is_string($dataOrControllerName)) {
+            trigger_deprecation('symfony/webpack-encore-bundle', 'v1.15.0', 'Passing an array as first argument of stimulus_target() is deprecated.');
+        }
+
         $dto->addTarget($dataOrControllerName, $targetNames);
 
         return $dto;