Tweaks after feedback

Author: weaverryan

src/Asset/TagRenderer.php

@@ -25,9 +25,6 @@ class TagRenderer implements ResetInterface
     private $defaultAttributes;
     private $defaultScriptAttributes;
     private $defaultLinkAttributes;
-    /**
-     * @var EventDispatcherInterface|null
-     */
     private $eventDispatcher;
 
     private $renderedFiles = [];
@@ -37,7 +34,8 @@ public function __construct(
         Packages $packages,
         array $defaultAttributes = [],
         array $defaultScriptAttributes = [],
-        array $defaultLinkAttributes = []
+        array $defaultLinkAttributes = [],
+        EventDispatcherInterface $eventDispatcher = null
     ) {
         if ($entrypointLookupCollection instanceof EntrypointLookupInterface) {
             @trigger_error(sprintf('The "$entrypointLookupCollection" argument in method "%s()" must be an instance of EntrypointLookupCollection.', __METHOD__), E_USER_DEPRECATED);
@@ -57,15 +55,11 @@ public function __construct(
         $this->defaultAttributes = $defaultAttributes;
         $this->defaultScriptAttributes = $defaultScriptAttributes;
         $this->defaultLinkAttributes = $defaultLinkAttributes;
+        $this->eventDispatcher = $eventDispatcher;
 
         $this->reset();
     }
 
-    public function setEventDispatcher(EventDispatcherInterface $eventDispatcher)
-    {
-        $this->eventDispatcher = $eventDispatcher;
-    }
-
     public function renderWebpackScriptTags(string $entryName, string $packageName = null, string $entrypointName = null, array $extraAttributes = []): string
     {
         $entrypointName = $entrypointName ?: '_default';

src/Event/RenderAssetTagEvent.php

@@ -12,7 +12,7 @@
 /**
  * Dispatched each time a script or link tag is rendered.
  */
-class RenderAssetTagEvent
+final class RenderAssetTagEvent
 {
     public const TYPE_SCRIPT = 'script';
     public const TYPE_LINK = 'link';

src/Resources/config/services.xml

@@ -20,9 +20,7 @@
             <argument type="collection"/> <!-- Default attributes-->
             <argument type="collection"/> <!-- Default script attributes -->
             <argument type="collection"/> <!-- Default link attributes -->
-            <call method="setEventDispatcher">
-                <argument type="service" id="event_dispatcher" />
-            </call>
+            <argument type="service" id="event_dispatcher" />
         </service>
 
         <service id="webpack_encore.twig_entry_files_extension" class="Symfony\WebpackEncoreBundle\Twig\EntryFilesTwigExtension">