From f530ac1f77bbaf5462868ea6c796ce0d1f63df8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A1bor=20Egyed?= Date: Sun, 16 Apr 2023 19:52:37 +0200 Subject: [PATCH 1/2] [Autocomplete] Fix BC and trigger deprecation for `EntityAutocompleterInterface` --- src/Autocomplete/src/AutocompleteResultsExecutor.php | 4 +++- src/Autocomplete/src/EntityAutocompleterInterface.php | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Autocomplete/src/AutocompleteResultsExecutor.php b/src/Autocomplete/src/AutocompleteResultsExecutor.php index 55a5e9f48cd..44014a3ad7c 100644 --- a/src/Autocomplete/src/AutocompleteResultsExecutor.php +++ b/src/Autocomplete/src/AutocompleteResultsExecutor.php @@ -71,7 +71,9 @@ public function fetchResults(EntityAutocompleterInterface $autocompleter, string $results = []; - if (null === $groupBy = $autocompleter->getGroupBy()) { + if (!method_exists($autocompleter, 'getGroupBy')) { + trigger_deprecation('symfony/ux-autocomplete', '2.8', 'Not implementing the "EntityAutocompleterInterface::getGroupBy()" in "%s" is deprecated.', get_debug_type($autocompleter)); + } elseif (null === $groupBy = $autocompleter->getGroupBy()) { foreach ($paginator as $entity) { $results[] = [ 'value' => $autocompleter->getValue($entity), diff --git a/src/Autocomplete/src/EntityAutocompleterInterface.php b/src/Autocomplete/src/EntityAutocompleterInterface.php index e26758843cf..700a05d7a50 100644 --- a/src/Autocomplete/src/EntityAutocompleterInterface.php +++ b/src/Autocomplete/src/EntityAutocompleterInterface.php @@ -17,6 +17,8 @@ /** * Interface for classes that will have an "autocomplete" endpoint exposed. + * + * @method mixed getGroupBy() Return group_by option. */ interface EntityAutocompleterInterface { @@ -50,5 +52,5 @@ public function isGranted(Security $security): bool; /** * Return group_by option. */ - public function getGroupBy(): mixed; + /* public function getGroupBy(): mixed; */ } From 4ca03b5fbcf259ef50032c14aecbf940bee209bb Mon Sep 17 00:00:00 2001 From: Ryan Weaver Date: Mon, 17 Apr 2023 10:49:21 -0400 Subject: [PATCH 2/2] fixing phpcs --- src/Autocomplete/src/EntityAutocompleterInterface.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Autocomplete/src/EntityAutocompleterInterface.php b/src/Autocomplete/src/EntityAutocompleterInterface.php index 700a05d7a50..c82b2ff8e46 100644 --- a/src/Autocomplete/src/EntityAutocompleterInterface.php +++ b/src/Autocomplete/src/EntityAutocompleterInterface.php @@ -49,7 +49,7 @@ public function getValue(object $entity): mixed; */ public function isGranted(Security $security): bool; - /** + /* * Return group_by option. */ /* public function getGroupBy(): mixed; */