bug #247 Fix Typescript alerts (tgalopin)

This PR was merged into the 2.x branch.

Discussion
----------

Fix Typescript alerts

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | -
| Tickets       | -
| License       | MIT

Fix Typescript alerts in controllers.

Commits
-------

b3b836b Fix Typescript alerts

Author: weaverryan

src/Chartjs/Resources/assets/src/controller.ts

@@ -13,6 +13,8 @@ import { Controller } from '@hotwired/stimulus';
 import Chart from 'chart.js/auto';
 
 export default class extends Controller {
+    readonly viewValue: any;
+
     static values = {
         view: Object,
     };

src/Cropperjs/Resources/assets/src/controller.ts

@@ -14,6 +14,9 @@ import Cropper from 'cropperjs';
 import CropEvent = Cropper.CropEvent;
 
 export default class CropperController extends Controller {
+    readonly publicUrlValue: string;
+    readonly optionsValue: object;
+
     static values = {
         publicUrl: String,
         options: Object,

src/Dropzone/Resources/assets/src/controller.ts

@@ -12,6 +12,13 @@
 import { Controller } from '@hotwired/stimulus';
 
 export default class extends Controller {
+    readonly inputTarget: HTMLInputElement;
+    readonly placeholderTarget: HTMLDivElement;
+    readonly previewTarget: HTMLDivElement;
+    readonly previewClearButtonTarget: HTMLButtonElement;
+    readonly previewFilenameTarget: HTMLDivElement;
+    readonly previewImageTarget: HTMLDivElement;
+
     static targets = ['input', 'placeholder', 'preview', 'previewClearButton', 'previewFilename', 'previewImage'];
 
     connect() {
@@ -39,7 +46,7 @@ export default class extends Controller {
         this._dispatchEvent('dropzone:clear');
     }
 
-    onInputChange(event) {
+    onInputChange(event: any) {
         const file = event.target.files[0];
         if (typeof file === 'undefined') {
             return;
@@ -62,23 +69,23 @@ export default class extends Controller {
         this._dispatchEvent('dropzone:change', file);
     }
 
-    _populateImagePreview(file) {
+    _populateImagePreview(file: Blob) {
         if (typeof FileReader === 'undefined') {
             // FileReader API not available, skip
             return;
         }
 
         const reader = new FileReader();
 
-        reader.addEventListener('load', (event) => {
+        reader.addEventListener('load', (event: any) => {
             this.previewImageTarget.style.display = 'block';
             this.previewImageTarget.style.backgroundImage = 'url("' + event.target.result + '")';
         });
 
         reader.readAsDataURL(file);
     }
 
-    _dispatchEvent(name: string, payload: any) {
+    _dispatchEvent(name: string, payload: any = {}) {
         this.element.dispatchEvent(new CustomEvent(name, { detail: payload }));
     }
 }

src/LazyImage/Resources/assets/src/controller.ts

@@ -12,20 +12,25 @@
 import { Controller } from '@hotwired/stimulus';
 
 export default class extends Controller {
+    readonly srcValue: string;
+    readonly srcsetValue: any;
+    readonly hasSrcsetValue: boolean;
+
     static values = {
         src: String,
         srcset: Object,
     };
 
     connect() {
         const hd = new Image();
+        const element = this.element as HTMLImageElement;
 
         const srcsetString = this._calculateSrcsetString();
 
         hd.addEventListener('load', () => {
-            this.element.src = this.srcValue;
+            element.src = this.srcValue;
             if (srcsetString) {
-                this.element.srcset = srcsetString;
+                element.srcset = srcsetString;
             }
             this._dispatchEvent('lazy-image:ready', { image: hd });
         });
@@ -43,7 +48,7 @@ export default class extends Controller {
             return '';
         }
 
-        const sets = Object.keys(this.srcsetValue).map((size) => {
+        const sets = Object.keys(this.srcsetValue).map((size: string) => {
             return `${this.srcsetValue[size]} ${size}`;
         });
 

src/LiveComponent/assets/src/live_controller.ts

@@ -190,7 +190,7 @@ export default class extends Controller {
     }
 
     _getValueFromElement(element: HTMLElement) {
-        return element.dataset.value || element.value;
+        return element.dataset.value || (element as any).value;
     }
 
     _updateModelFromElement(element: HTMLElement, value: string, shouldRender: boolean) {
@@ -360,7 +360,7 @@ export default class extends Controller {
             if (typeof Turbo !== 'undefined') {
                 Turbo.visit(response.headers.get('Location'));
             } else {
-                window.location.href = response.headers.get('Location');
+                window.location.href = response.headers.get('Location') || '';
             }
 
             return;
@@ -609,7 +609,7 @@ export default class extends Controller {
         let callback: () => void;
         if (actionName.charAt(0) === '$') {
             callback = () => {
-                this[actionName]();
+                (this as any)[actionName]();
             }
         } else {
             callback = () => {

src/Swup/Resources/assets/src/controller.ts

@@ -17,6 +17,19 @@ import SwupFadeTheme from '@swup/fade-theme';
 import SwupSlideTheme from '@swup/slide-theme';
 
 export default class extends Controller {
+    animateHistoryBrowsingValue: boolean;
+    hasAnimateHistoryBrowsingValue: boolean;
+    animationSelectorValue: string;
+    hasAnimationSelectorValue: boolean;
+    cacheValue: boolean;
+    hasCacheValue: boolean;
+    containersValue: string[];
+    hasContainersValue: boolean;
+    linkSelectorValue: string;
+    hasLinkSelectorValue: boolean;
+    themeValue: string;
+    debugValue: boolean;
+
     static values = {
         animateHistoryBrowsing: Boolean,
         animationSelector: String,
@@ -30,7 +43,7 @@ export default class extends Controller {
     };
 
     connect() {
-        const options = {
+        const options: any = {
             containers: ['#swup'],
             plugins: ['slide' === this.themeValue ? new SwupSlideTheme() : new SwupFadeTheme(), new SwupFormsPlugin()],
         };

tsconfig.json

@@ -6,6 +6,7 @@
         "noUnusedLocals": true,
         "rootDir": "src",
         "strict": true,
+        "strictPropertyInitialization": false,
         "target": "es2017",
         "removeComments": true,
         "outDir": "dist",