Skip to content

Commit 7fecfaa

Browse files
committed
minor #158 Fix phpunit bridge with custom path (weaverryan)
This PR was squashed before being merged into the main branch. Discussion ---------- Fix phpunit bridge with custom path | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | Fixes tests! | License | MIT A workaround for symfony/symfony#43877 - though I'm not sure if we have a good reason for choosing a custom directory in the first place... so this might be completely fine. Also, I'm not sure if we need the PHPUnit version - I had already removed it in another PR because (iirc) it was causing some issues. Commits ------- 56141b3 removing unnecessary ignore 5f12f2e removing custom PHPUnit directory and specific PHPUnit version
2 parents 7e89a4f + 56141b3 commit 7fecfaa

File tree

2 files changed

+0
-5
lines changed

2 files changed

+0
-5
lines changed

.github/workflows/test.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@ name: Symfony UX
22

33
on: [push, pull_request]
44

5-
env:
6-
SYMFONY_PHPUNIT_DIR: '/tmp/.phpunit'
7-
SYMFONY_PHPUNIT_VERSION: '8.5'
8-
95
jobs:
106
coding-style-php:
117
runs-on: ubuntu-latest

src/Turbo/Doctrine/BroadcastListener.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ private function storeEntitiesToPublish(EntityManagerInterface $em, object $enti
129129

130130
if (\PHP_VERSION_ID >= 80000 && $options = ($r = new \ReflectionClass($class))->getAttributes(Broadcast::class)) {
131131
$options = $options[0]->newInstance();
132-
// @phpstan-ignore-next-line
133132
$this->broadcastedClasses[$class] = $options->options;
134133
} elseif ($this->annotationReader && $options = $this->annotationReader->getClassAnnotation($r ?? new \ReflectionClass($class), Broadcast::class)) {
135134
$this->broadcastedClasses[$class] = $options->options;

0 commit comments

Comments
 (0)