Create controller per version

Author: evertharmeling

src/Chartjs/assets/package.json

@@ -7,11 +7,19 @@
     "types": "dist/controller.d.ts",
     "symfony": {
         "controllers": {
-            "chart": {
-                "main": "dist/controller.js",
+            "chart_v3": {
+                "main": "dist/chart_v3_controller.js",
+                "name": "symfony--ux-chartjs--chart",
                 "webpackMode": "eager",
                 "fetch": "eager",
                 "enabled": true
+            },
+            "chart_v4": {
+                "main": "dist/chart_v4_controller.js",
+                "name": "symfony--ux-chartjs--chart",
+                "webpackMode": "eager",
+                "fetch": "eager",
+                "enabled": false
             }
         }
     },

src/Chartjs/assets/src/controller.ts renamed to src/Chartjs/assets/src/abstract_controller.ts

@@ -10,9 +10,8 @@
 'use strict';
 
 import { Controller } from '@hotwired/stimulus';
-import Chart from 'chart.js/auto';
 
-export default class extends Controller {
+export default abstract class AbstractChartController extends Controller {
     declare readonly viewValue: any;
 
     static values = {
@@ -35,12 +34,17 @@ export default class extends Controller {
         if (!canvasContext) {
             throw new Error('Could not getContext() from Element');
         }
-        const chart = new Chart(canvasContext, payload);
+        const chart = this.createChart(canvasContext, payload);
 
         this._dispatchEvent('chartjs:connect', { chart });
     }
 
     _dispatchEvent(name: string, payload: any) {
         this.element.dispatchEvent(new CustomEvent(name, { detail: payload }));
     }
+
+    /**
+     * To support v3 and v4 of chart.js this help function is added, could be refactored when support for v3 is dropped
+     */
+    abstract createChart(canvasContext: any, payload: any): any;
 }

src/Chartjs/assets/src/chart_v3_controller.ts

@@ -0,0 +1,20 @@
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+'use strict';
+
+import AbstractChartController from './abstract_controller';
+import Chart from 'chart.js/auto';
+import { ChartConfiguration, ChartItem } from 'chart.js';
+
+export default class extends AbstractChartController {
+    createChart(canvasContext: ChartItem, payload: ChartConfiguration): any {
+        return new Chart(canvasContext, payload);
+    }
+}

src/Chartjs/assets/src/chart_v4_controller.ts

@@ -0,0 +1,20 @@
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+'use strict';
+
+import AbstractChartController from './abstract_controller';
+import Chart from 'chart.js/auto';
+import { ChartConfiguration, ChartItem } from 'chart.js';
+
+export default class extends AbstractChartController {
+    createChart(canvasContext: ChartItem, payload: ChartConfiguration): any {
+        return new Chart(canvasContext, payload);
+    }
+}