make remove method immutable and test if attributes are still render

Author: matheo

src/TwigComponent/src/ComponentAttributes.php

@@ -149,8 +149,12 @@ public function add($stimulusDto): self
         return $clone->defaults($controllersAttributes);
     }
 
-    public function remove($key): void
+    public function remove($key): self
     {
-        unset($this->attributes[$key]);
+        $attributes = $this->attributes;
+
+        unset($attributes[$key]);
+
+        return new self($attributes);
     }
 }

src/TwigComponent/src/Twig/PropsNode.php

@@ -31,7 +31,7 @@ public function compile(Compiler $compiler): void
         foreach ($this->getAttribute('names') as $name) {
             $compiler
                 ->addDebugInfo($this)
-                ->write('$context[\'attributes\']->remove(\''.$name.'\');')
+                ->write('$context[\'attributes\'] = $context[\'attributes\']->remove(\''.$name.'\');')
                 ->write('if (!isset($context[\''.$name.'\'])) {')
             ;
 

src/TwigComponent/tests/Fixtures/templates/anonymous_component_none_scalar_prop.html.twig

@@ -1 +1 @@
-<twig:UserCard :user='user'/>
+<twig:UserCard :user='user' class='foo'/>

src/TwigComponent/tests/Fixtures/templates/components/UserCard.html.twig

@@ -1,6 +1,6 @@
 {% props user %}
 
-<div {{ attributes }} class='user-card'>
+<div {{ attributes }}>
     <p>{{ user.name }}</p>
     <p>{{ user.email }}</p>
 </div>

src/TwigComponent/tests/Integration/ComponentExtensionTest.php

@@ -189,6 +189,7 @@ public function testRenderAnonymousComponentWithNonScalarProps(): void
 
         $output = self::getContainer()->get(Environment::class)->render('anonymous_component_none_scalar_prop.html.twig', ['user' => $user]);
 
+        $this->assertStringContainsString('class="foo"', $output);
         $this->assertStringContainsString('Fabien', $output);
         $this->assertStringContainsString('[email protected]', $output);
     }