bug #367 [Autocomplete] Not destroyed on disconnect() (mpiot)

weaverryan · weaverryan · commit 0699d44fa67e · 2022-06-23T10:23:42.000-04:00
This PR was merged into the 2.x branch. Discussion ---------- [Autocomplete] Not destroyed on disconnect() | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Tickets | Fix #366 | License | MIT Call the `destroy()` method from TomSelect on `disconnect` event of the Controller. (https://tom-select.js.org/docs/api/) Commits ------- 94d1972 Add disconnect() method
diff --git a/src/Autocomplete/assets/src/controller.ts b/src/Autocomplete/assets/src/controller.ts
@@ -39,6 +39,10 @@ export default class extends Controller {
         this.tomSelect = this.#createAutocomplete();
     }
 
+    disconnect() {
+        this.tomSelect.destroy();
+    }
+
     #getCommonConfig(): Partial<TomSettings> {
         const plugins: any = {}
 

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,10 @@ export default class extends Controller {`
`39`	`39`	`this.tomSelect = this.#createAutocomplete();`
`40`	`40`	`}`
`41`	`41`
	`42`	`+ disconnect() {`
	`43`	`+ this.tomSelect.destroy();`
	`44`	`+ }`
	`45`	`+`
`42`	`46`	`#getCommonConfig(): Partial<TomSettings> {`
`43`	`47`	`const plugins: any = {}`
`44`	`48`