Skip to content

Commit e3bf421

Browse files
committed
minor #21409 Escape user data in server-data.rst (dave1010)
This PR was merged into the 6.4 branch. Discussion ---------- Escape user data in server-data.rst Escape user data for HTML attributes to prevent XSS. This is already done in the second code snippet below. Twig playground demo: https://twig.symfony.com/play?data=eyJ0ZW1wbGF0ZXMiOltbImluZGV4LnR3aWciLCI8ZGl2IGRhdGEtZm9vPVwiTm90IGVuY29kZWQge3sgbmFtZXxqc29uX2VuY29kZSB9fVwiPlxuXG48ZGl2IGRhdGEtZm9vPVwiRW5jb2RlZCB7eyBuYW1lfGpzb25fZW5jb2RlfGUoJ2h0bWxfYXR0cicpIH19XCI%2BIl1dLCJjb250ZXh0Ijp7Im5hbWUiOiJXb3JsZCJ9LCJ2ZXJzaW9uIjoiMy4yMS4xIiwib3B0aW9ucyI6eyJzdHJpY3RfdmFyaWFibGVzIjp0cnVlLCJjaGFyc2V0IjoiVVRGLTgiLCJhdXRvZXNjYXBlIjoiIn19 Commits ------- fb0b35d Escape user data in server-data.rst
2 parents b2b6f26 + fb0b35d commit e3bf421

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

frontend/server-data.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ them later in JavaScript. For example:
1010

1111
<div class="js-user-rating"
1212
data-is-authenticated="{{ app.user ? 'true' : 'false' }}"
13-
data-user="{{ app.user|serialize(format = 'json') }}"
13+
data-user="{{ app.user|serialize(format = 'json')|e('html_attr') }}"
1414
>
1515
<!-- ... -->
1616
</div>

0 commit comments

Comments
 (0)