Skip to content
This repository was archived by the owner on May 31, 2024. It is now read-only.

Commit 5cdd3c6

Browse files
Merge branch '3.4' into 4.3
* 3.4: Fix assertInternalType deprecation in phpunit 9 Micro-typo fix
2 parents f9f217a + 958cb89 commit 5cdd3c6

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

Http/RememberMe/TokenBasedRememberMeServices.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ protected function generateCookieValue($class, $username, $expires, $password)
111111
}
112112

113113
/**
114-
* Generates a hash for the cookie to ensure it is not being tempered with.
114+
* Generates a hash for the cookie to ensure it is not being tampered with.
115115
*
116116
* @param string $class
117117
* @param string $username The username

Http/Tests/RememberMe/AbstractRememberMeServicesTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,16 @@
1212
namespace Symfony\Component\Security\Http\Tests\RememberMe;
1313

1414
use PHPUnit\Framework\TestCase;
15+
use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
1516
use Symfony\Component\HttpFoundation\Request;
1617
use Symfony\Component\HttpFoundation\Response;
1718
use Symfony\Component\Security\Http\RememberMe\AbstractRememberMeServices;
1819
use Symfony\Component\Security\Http\RememberMe\RememberMeServicesInterface;
1920

2021
class AbstractRememberMeServicesTest extends TestCase
2122
{
23+
use ForwardCompatTestTrait;
24+
2225
public function testGetRememberMeParameter()
2326
{
2427
$service = $this->getService(null, ['remember_me_parameter' => 'foo']);
@@ -261,7 +264,7 @@ public function testEncodeCookieAndDecodeCookieAreInvertible()
261264
$service = $this->getService();
262265

263266
$encoded = $this->callProtected($service, 'encodeCookie', [$cookieParts]);
264-
$this->assertInternalType('string', $encoded);
267+
$this->assertIsString($encoded);
265268

266269
$decoded = $this->callProtected($service, 'decodeCookie', [$encoded]);
267270
$this->assertSame($cookieParts, $decoded);

0 commit comments

Comments
 (0)