Use typed properties in tests as much as possible

nicolas-grekas · nicolas-grekas · commit 1132f6e0988f · 2023-07-25T10:53:33.000+02:00
diff --git a/Tests/ExecutableFinderTest.php b/Tests/ExecutableFinderTest.php
@@ -19,7 +19,7 @@
  */
 class ExecutableFinderTest extends TestCase
 {
-    private $path;
+    private string|false $path = false;
 
     protected function tearDown(): void
     {
diff --git a/Tests/ProcessTest.php b/Tests/ProcessTest.php
@@ -28,9 +28,9 @@
  */
 class ProcessTest extends TestCase
 {
-    private static $phpBin;
-    private static $process;
-    private static $sigchild;
+    private static string $phpBin;
+    private static ?Process $process = null;
+    private static bool $sigchild;
 
     public static function setUpBeforeClass(): void
     {

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`*/`
`20`	`20`	`class ExecutableFinderTest extends TestCase`
`21`	`21`	`{`
`22`		`- private $path;`
	`22`	`+ private string\|false $path = false;`
`23`	`23`
`24`	`24`	`protected function tearDown(): void`
`25`	`25`	`{`
Original file line number	Diff line number	Diff line change
`@@ -28,9 +28,9 @@`
`28`	`28`	`*/`
`29`	`29`	`class ProcessTest extends TestCase`
`30`	`30`	`{`
`31`		`- private static $phpBin;`
`32`		`- private static $process;`
`33`		`- private static $sigchild;`
	`31`	`+ private static string $phpBin;`
	`32`	`+ private static ?Process $process = null;`
	`33`	`+ private static bool $sigchild;`
`34`	`34`
`35`	`35`	`public static function setUpBeforeClass(): void`
`36`	`36`	`{`