skipping tests before DoctrineMigrationsBundle 3

Author: weaverryan

composer.json

@@ -25,6 +25,7 @@
         "symfony/http-kernel": "^3.4|^4.0|^5.0"
     },
     "require-dev": {
+        "composer/semver": "^3.0@dev",
         "doctrine/doctrine-bundle": "^1.8|^2.0",
         "doctrine/orm": "^2.3",
         "friendsofphp/php-cs-fixer": "^2.8",

src/Test/MakerTestCase.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Bundle\MakerBundle\Test;
 
+use Composer\Semver\Semver;
 use PHPUnit\Framework\TestCase;
 use Symfony\Bundle\MakerBundle\MakerInterface;
 use Symfony\Bundle\MakerBundle\Str;
@@ -40,6 +41,10 @@ protected function executeMakerCommand(MakerTestDetails $testDetails)
         // prepare environment to test
         $testEnv->prepare();
 
+        if (!$this->hasRequiredDependencyVersions($testDetails, $testEnv)) {
+            $this->markTestSkipped('Some dependencies versions are too low');
+        }
+
         // run tests
         $makerTestProcess = $testEnv->runMaker();
         $files = $testEnv->getGeneratedFilesFromOutputText();
@@ -95,4 +100,32 @@ protected function getMakerInstance(string $makerClass): MakerInterface
 
         return $this->kernel->getContainer()->get($serviceId);
     }
+
+    private function hasRequiredDependencyVersions(MakerTestDetails $testDetails, MakerTestEnvironment $testEnv): bool
+    {
+        if (empty($testDetails->getRequiredPackageVersions())) {
+            return true;
+        }
+
+        $installedPackages = json_decode($testEnv->readFile('vendor/composer/installed.json'), true);
+        $packageVersions = [];
+        foreach ($installedPackages as $installedPackage) {
+            $packageVersions[$installedPackage['name']] = $installedPackage['version_normalized'];
+        }
+
+        foreach ($testDetails->getRequiredPackageVersions() as $requiredPackageData) {
+            $name = $requiredPackageData['name'];
+            $versionConstraint = $requiredPackageData['version_constraint'];
+
+            if (!isset($packageVersions[$name])) {
+                throw new \Exception(sprintf('Package "%s" is required in the test project at version "%s" but it is not installed?', $name, $versionConstraint));
+            }
+
+            if (!Semver::satisfies($packageVersions[$name], $versionConstraint)) {
+                return false;
+            }
+        }
+
+        return true;
+    }
 }

src/Test/MakerTestDetails.php

@@ -44,6 +44,8 @@ final class MakerTestDetails
 
     private $requiredPhpVersion;
 
+    private $requiredPackageVersions = [];
+
     private $guardAuthenticators = [];
 
     /**
@@ -216,6 +218,13 @@ public function setRequiredPhpVersion(int $version): self
         return $this;
     }
 
+    public function addRequiredPackageVersion(string $packageName, string $versionConstraint): self
+    {
+        $this->requiredPackageVersions[] = ['name' => $packageName, 'version_constraint' => $versionConstraint];
+
+        return $this;
+    }
+
     public function setGuardAuthenticator(string $firewallName, string $id): self
     {
         $this->guardAuthenticators[$firewallName] = $id;
@@ -316,4 +325,9 @@ public function getGuardAuthenticators(): array
     {
         return $this->guardAuthenticators;
     }
+
+    public function getRequiredPackageVersions(): array
+    {
+        return $this->requiredPackageVersions;
+    }
 }

src/Test/MakerTestEnvironment.php

@@ -69,6 +69,15 @@ public function getPath(): string
         return $this->path;
     }
 
+    public function readFile(string $path): string
+    {
+        if (!file_exists($this->path.'/'.$path)) {
+            throw new \InvalidArgumentException(sprintf('Cannot find file "%s"', $path));
+        }
+
+        return file_get_contents($this->path.'/'.$path);
+    }
+
     private function changeRootNamespaceIfNeeded()
     {
         if ('App' === ($rootNamespace = $this->testDetails->getRootNamespace())) {

tests/Maker/MakeMigrationTest.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Bundle\MakerBundle\Tests\Maker;
 
+use Doctrine\Bundle\MigrationsBundle\Command\MigrationsDiffDoctrineCommand;
 use Symfony\Bundle\MakerBundle\Maker\MakeMigration;
 use Symfony\Bundle\MakerBundle\Test\MakerTestCase;
 use Symfony\Bundle\MakerBundle\Test\MakerTestDetails;
@@ -67,16 +68,16 @@ public function getTestDetails()
                 // confirm migration
                 'y',
             ])
-            ->setFixtureFilesPath(__DIR__.'/../fixtures/MakeMigration')
+            ->setFixtureFilesPath(__DIR__ . '/../fixtures/MakeMigration')
             ->configureDatabase(false)
+            ->addRequiredPackageVersion('doctrine/doctrine-migrations-bundle', '>=3')
             ->addExtraDependencies('doctrine/orm:@stable')
             // generate a migration first
             ->addPreMakeCommand('php bin/console make:migration')
             ->assert(function (string $output, string $directory) {
                 $this->assertStringContainsString('You have 1 available migrations to execute', $output);
                 $this->assertStringContainsString('Success', $output);
                 $this->assertCount(14, explode("\n", $output), 'Asserting that very specific output is shown - some should be hidden');
-                var_dump($output);
             }),
         ];
 
@@ -86,8 +87,9 @@ public function getTestDetails()
                 // no to confirm
                 'n',
             ])
-            ->setFixtureFilesPath(__DIR__.'/../fixtures/MakeMigration')
+            ->setFixtureFilesPath(__DIR__ . '/../fixtures/MakeMigration')
             ->configureDatabase(false)
+            ->addRequiredPackageVersion('doctrine/doctrine-migrations-bundle', '>=3')
             ->addExtraDependencies('doctrine/orm:@stable')
             // generate a migration first
             ->addPreMakeCommand('php bin/console make:migration')