Merge branch '5.4' into 6.2

* 5.4:
  Migrate to `static` data providers using `rector/rector`

Author: nicolas-grekas

Tests/CurrenciesTest.php

@@ -674,7 +674,7 @@ public function testGetSymbol($displayLocale)
         }
     }
 
-    public function provideCurrencies()
+    public static function provideCurrencies()
     {
         return array_map(
             function ($currency) { return [$currency]; },
@@ -701,7 +701,7 @@ public function testGetRoundingIncrement($currency)
         $this->assertIsNumeric(Currencies::getRoundingIncrement($currency));
     }
 
-    public function provideCurrenciesWithNumericEquivalent()
+    public static function provideCurrenciesWithNumericEquivalent()
     {
         return array_map(
             function ($value) { return [$value]; },
@@ -717,7 +717,7 @@ public function testGetNumericCode($currency)
         $this->assertSame(self::ALPHA3_TO_NUMERIC[$currency], Currencies::getNumericCode($currency));
     }
 
-    public function provideCurrenciesWithoutNumericEquivalent()
+    public static function provideCurrenciesWithoutNumericEquivalent()
     {
         return array_map(
             function ($value) { return [$value]; },
@@ -734,7 +734,7 @@ public function testGetNumericCodeFailsIfNoNumericEquivalent($currency)
         Currencies::getNumericCode($currency);
     }
 
-    public function provideValidNumericCodes()
+    public static function provideValidNumericCodes()
     {
         $numericToAlpha3 = $this->getNumericToAlpha3Mapping();
 
@@ -759,7 +759,7 @@ public function testForNumericCode($numeric, $expected)
         $this->assertSame($expected, $actual);
     }
 
-    public function provideInvalidNumericCodes()
+    public static function provideInvalidNumericCodes()
     {
         $validNumericCodes = array_keys($this->getNumericToAlpha3Mapping());
         $invalidNumericCodes = array_diff(range(0, 1000), $validNumericCodes);

Tests/Data/Bundle/Reader/BundleEntryReaderTest.php

@@ -165,7 +165,7 @@ public function testDontFallbackIfLocaleDoesNotExistAndFallbackDisabled()
         $this->reader->readEntry(self::RES_DIR, 'en_GB', ['Entries', 'Bam'], false);
     }
 
-    public function provideMergeableValues()
+    public static function provideMergeableValues()
     {
         return [
             ['foo', null, 'foo'],

Tests/LanguagesTest.php

@@ -1742,7 +1742,7 @@ public function testGetNameDefaultLocale()
         }
     }
 
-    public function provideLanguagesWithAlpha3Equivalent()
+    public static function provideLanguagesWithAlpha3Equivalent()
     {
         return array_map(
             function ($value) { return [$value]; },
@@ -1758,7 +1758,7 @@ public function testGetAlpha3Code($language)
         $this->assertSame(self::ALPHA2_TO_ALPHA3[$language], Languages::getAlpha3Code($language));
     }
 
-    public function provideLanguagesWithoutAlpha3Equivalent()
+    public static function provideLanguagesWithoutAlpha3Equivalent()
     {
         return array_map(
             function ($value) { return [$value]; },
@@ -1792,7 +1792,7 @@ public function testGetAlpha3Codes()
         $this->assertSame(self::ALPHA3_CODES, Languages::getAlpha3Codes());
     }
 
-    public function provideLanguagesWithAlpha2Equivalent()
+    public static function provideLanguagesWithAlpha2Equivalent()
     {
         return array_map(
             function ($value) { return [$value]; },
@@ -1808,7 +1808,7 @@ public function testGetAlpha2Code($language)
         $this->assertSame(self::ALPHA3_TO_ALPHA2[$language], Languages::getAlpha2Code($language));
     }
 
-    public function provideLanguagesWithoutAlpha2Equivalent()
+    public static function provideLanguagesWithoutAlpha2Equivalent()
     {
         return array_map(
             function ($value) { return [$value]; },

Tests/LocaleTest.php

@@ -16,7 +16,7 @@
 
 class LocaleTest extends TestCase
 {
-    public function provideGetFallbackTests()
+    public static function provideGetFallbackTests()
     {
         $tests = [
             ['sl_Latn_IT', 'sl_Latn_IT_nedis'],

Tests/TimezonesTest.php

@@ -639,7 +639,7 @@ public function testGetCountryCodeAvailability(string $timezone)
         }
     }
 
-    public function provideTimezones(): iterable
+    public static function provideTimezones(): iterable
     {
         return array_map(function ($timezone) {
             return [$timezone];
@@ -657,7 +657,7 @@ public function testForCountryCodeAvailability(string $country)
         $this->addToAssertionCount(1);
     }
 
-    public function provideCountries(): iterable
+    public static function provideCountries(): iterable
     {
         return array_map(function ($country) {
             return [$country];

Tests/Transliterator/EmojiTransliteratorTest.php

@@ -30,7 +30,7 @@ public function testTransliterate(string $locale, string $input, string $expecte
         $this->assertSame($expected, $tr->transliterate($input));
     }
 
-    public function provideTransliterateTests(): iterable
+    public static function provideTransliterateTests(): iterable
     {
         yield [
             'fr',
@@ -76,7 +76,7 @@ public function testAllTransliterator(string $locale)
         $this->assertNotEmpty($tr->transliterate('😀'));
     }
 
-    public function provideLocaleTest(): iterable
+    public static function provideLocaleTest(): iterable
     {
         $file = (new Finder())
             ->in(__DIR__.'/../../Resources/data/transliterator/emoji')

Tests/Util/IcuVersionTest.php

@@ -19,7 +19,7 @@
  */
 class IcuVersionTest extends TestCase
 {
-    public function normalizeProvider()
+    public static function normalizeProvider()
     {
         return [
             [null, '1', '10'],
@@ -49,7 +49,7 @@ public function testNormalize($precision, $version, $result)
         $this->assertSame($result, IcuVersion::normalize($version, $precision));
     }
 
-    public function compareProvider()
+    public static function compareProvider()
     {
         return [
             [null, '1', '==', '1', true],

Tests/Util/VersionTest.php

@@ -19,7 +19,7 @@
  */
 class VersionTest extends TestCase
 {
-    public function normalizeProvider()
+    public static function normalizeProvider()
     {
         return [
             [null, '1', '1'],
@@ -53,7 +53,7 @@ public function testNormalize($precision, $version, $result)
         $this->assertSame($result, Version::normalize($version, $precision));
     }
 
-    public function compareProvider()
+    public static function compareProvider()
     {
         return [
             [null, '1', '==', '1', true],