Add a missing command to build Sass files #1471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
force-pushed
the
fix_install
branch
from
121ce51 to
4137bb5
Compare
Member
Author
|
Asking @weaverryan to see if he can verify that this is indeed needed ... or if the best solution is something different. Thanks! |
weaverryan
approved these changes
Dec 11, 2023
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Yup - because I already had this file built locally, I forgot about this. Normally, users will run this manually - e.g. sass:build -w in watch mode. However, because we want the demo to be useable immediately when you clone, putting it in scripts makes sense. This downloads the sass binary, which is only 3mb on most systems - https://github.com/sass/dart-sass/releases/tag/1.69.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #1449 I saw this error when running the app: