minor #448 Tweaked the new blog post tags feature (javiereguiluz)

This PR was squashed before being merged into the master branch (closes #448).

Discussion
----------

Tweaked the new blog post tags feature

This continues #447 and introduces some minor changes.

---

The only relevant changes for end users is the minor redesign of the tags. For example, in the blog index, before tags stand out too much and they look like buttons:

![index-before](https://cloud.githubusercontent.com/assets/73419/22641958/1681671e-ec59-11e6-8178-e60b0eff9a4f.png)

Now they are faded because, after all, they are a secondary information:

![index-after](https://cloud.githubusercontent.com/assets/73419/22641977/22e349d2-ec59-11e6-9974-85565c9a565d.png)

In the blog post show, the tags are bigger:

![show-after](https://cloud.githubusercontent.com/assets/73419/22641984/2939dc1a-ec59-11e6-952c-fe1d53dc0b04.png)

And in the admin, I haven't modified anything, so they still look like this:

![admin-after](https://cloud.githubusercontent.com/assets/73419/22642002/391c0e6e-ec59-11e6-8e8c-f23f7267bc99.png)

Commits
-------

f09c564 Tweaked the new blog post tags feature

Author: javiereguiluz

app/Resources/translations/validators.en.xlf

@@ -14,9 +14,9 @@
                 <source>post.too_short_content</source>
                 <target>Post content is too short ({{ limit }} characters minimum)</target>
             </trans-unit>
-            <trans-unit id="post.too_much_tags">
-                <source>post.too_much_tags</source>
-                <target>Too much tags ({{ limit }} maximum)</target>
+            <trans-unit id="post.too_many_tags">
+                <source>post.too_many_tags</source>
+                <target>Too many tags (add {{ limit }} tags or less)</target>
             </trans-unit>
             <trans-unit id="comment.blank">
                 <source>comment.blank</source>

app/Resources/translations/validators.es.xlf

@@ -14,9 +14,9 @@
                 <source>post.too_short_content</source>
                 <target>El contenido del artículo es demasiado corto ({{ limit }} caracteres como mínimo)</target>
             </trans-unit>
-            <trans-unit id="post.too_much_tags">
-                <source>post.too_much_tags</source>
-                <target>Demasiadas etiquetas ({{ limit }} como máximo)</target>
+            <trans-unit id="post.too_many_tags">
+                <source>post.too_many_tags</source>
+                <target>Demasiadas etiquetas (añade {{ limit }} como máximo)</target>
             </trans-unit>
             <trans-unit id="comment.blank">
                 <source>comment.blank</source>

app/Resources/views/blog/_post_tags.html.twig

@@ -1,7 +1,7 @@
 {% if not post.tags.empty %}
     <p class="post-tags">
         {% for tag in post.tags %}
-            <span class="label label-success">
+            <span class="label label-default">
                 <i class="fa fa-tag"></i> {{ tag.name }}
             </span>
         {% endfor %}

app/Resources/views/blog/index.html.twig

@@ -11,14 +11,14 @@
                 </a>
             </h2>
 
-            {{ include('blog/_post_tags.html.twig') }}
-
             <p class="post-metadata">
                 <span class="metadata"><i class="fa fa-calendar"></i> {{ post.publishedAt|localizeddate('long', 'medium', null, 'UTC') }}</span>
                 <span class="metadata"><i class="fa fa-user"></i> {{ post.author.email }}</span>
             </p>
 
             {{ post.summary|md2html }}
+
+            {{ include('blog/_post_tags.html.twig') }}
         </article>
     {% else %}
         <div class="well">{{ 'post.no_posts_found'|trans }}</div>

app/config/services.yml

@@ -22,9 +22,8 @@ services:
         tags:
             - { name: twig.extension }
 
-    # This is only needed if your form type requires some dependencies to be injected
-    # by the container, otherwise it is unnecessary overhead and therefore not recommended
-    # to do this for all form type classes.
+    # Defining a form type as a service is only required when the form type
+    # needs to use some other services, such as the entity manager.
     # See http://symfony.com/doc/current/best_practices/forms.html
     app.form.type.tagsinput:
         class: AppBundle\Form\Type\TagsInputType

src/AppBundle/DataFixtures/ORM/PostFixtures.php

@@ -21,10 +21,8 @@
 use Symfony\Component\DependencyInjection\ContainerAwareTrait;
 
 /**
- * Defines the sample data to load in the database when running the unit and
- * functional tests.
- *
- * Execute this command to load the data:
+ * Defines the sample blog posts to load in the database before running the unit
+ * and functional tests. Execute this command to load the data.
  *
  *   $ php bin/console doctrine:fixtures:load
  *
@@ -53,8 +51,9 @@ public function load(ObjectManager $manager)
             $post->setSummary($this->getRandomPostSummary());
             $post->setSlug($this->container->get('slugger')->slugify($post->getTitle()));
             $post->setContent($this->getPostContent());
-            // This reference has been added in UserFixtures class and contains
-            // an instance of User entity.
+            // "References" are the way to share objects between fixtures defined
+            // in different files. This reference has been added in the UserFixtures
+            // file and it contains an instance of the User entity.
             $post->setAuthor($this->getReference('anna-admin'));
             $post->setPublishedAt(new \DateTime('now - '.$i.'days'));
 
@@ -79,8 +78,9 @@ public function load(ObjectManager $manager)
     }
 
     /**
-     * This method must return an array of fixtures classes
-     * on which the implementing class depends on.
+     * Instead of defining the exact order in which the fixtures files must be loaded,
+     * this method defines which other fixtures this file depends on. Then, Doctrine
+     * will figure out the best order to fit all the dependencies.
      *
      * @return array
      */
@@ -170,14 +170,14 @@ private function getPhrases()
             'Eposs sunt solems de superbus fortis',
             'Vae humani generis',
             'Diatrias tolerare tanquam noster caesium',
-            'Teres talis orgias saepe tractare de camerarius flavum sensorem',
+            'Teres talis saepe tractare de camerarius flavum sensorem',
             'Silva de secundus galatae demitto quadra',
             'Sunt accentores vitare salvus flavum parses',
-            'Potus sensim ducunt ad ferox abnoba',
+            'Potus sensim ad ferox abnoba',
             'Sunt seculaes transferre talis camerarius fluctuies',
             'Era brevis ratione est',
             'Sunt torquises imitari velox mirabilis medicinaes',
-            'Cum mineralis persuadere omnes finises desiderium bi-color',
+            'Mineralis persuadere omnes finises desiderium',
             'Bassus fatalis classiss virtualiter transferre de flavum',
         ];
     }

src/AppBundle/DataFixtures/ORM/TagFixtures.php

@@ -16,10 +16,8 @@
 use Doctrine\Common\Persistence\ObjectManager;
 
 /**
- * Defines the sample data to load in the database when running the unit and
- * functional tests.
- *
- * Execute this command to load the data:
+ * Defines the sample blog tags to load in the database before running the unit
+ * and functional tests. Execute this command to load the data.
  *
  *   $ php bin/console doctrine:fixtures:load
  *
@@ -30,7 +28,7 @@
 class TagFixtures extends AbstractFixture
 {
     public static $names = [
-        'Lorem',
+        'lorem',
         'ipsum',
         'consectetur',
         'adipiscing',

src/AppBundle/DataFixtures/ORM/UserFixtures.php

@@ -18,10 +18,8 @@
 use Symfony\Component\DependencyInjection\ContainerAwareTrait;
 
 /**
- * Defines the sample data to load in the database when running the unit and
- * functional tests.
- *
- * Execute this command to load the data:
+ * Defines the sample users to load in the database befre running the unit and
+ * functional tests. Execute this command to load the data.
  *
  *   $ php bin/console doctrine:fixtures:load
  *

src/AppBundle/Entity/Post.php

@@ -105,7 +105,7 @@ class Post
      *
      * @ORM\ManyToMany(targetEntity="AppBundle\Entity\Tag", cascade={"persist"})
      * @ORM\JoinTable(name="symfony_demo_post_tag")
-     * @Assert\Count(max="4", maxMessage="post.too_much_tags")
+     * @Assert\Count(max="4", maxMessage="post.too_many_tags")
      */
     private $tags;
 

tests/AppBundle/Controller/DefaultControllerTest.php

@@ -11,6 +11,7 @@
 
 namespace Tests\AppBundle\Controller;
 
+use AppBundle\Entity\Post;
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
 
 /**
@@ -43,6 +44,23 @@ public function testPublicUrls($url)
         );
     }
 
+    /**
+     * A good practice for tests is to not use the service container, to make
+     * them more robust. However, in this example we must access to the container
+     * to get the entity manager and make a database query. The reason is that
+     * blog post fixtures are randomly generated and there's no guarantee that
+     * a given blog post slug will be available.
+     */
+    public function testPublicBlogPost()
+    {
+        // the service container is always available via the client
+        $client = self::createClient();
+        $blogPost = $client->getContainer()->get('doctrine')->getRepository(Post::class)->find(1);
+        $client->request('GET', sprintf('/en/blog/posts/%s', $blogPost->getSlug()));
+
+        $this->assertTrue($client->getResponse()->isSuccessful());
+    }
+
     /**
      * The application contains a lot of secure URLs which shouldn't be
      * publicly accessible. This tests ensures that whenever a user tries to
@@ -68,7 +86,6 @@ public function getPublicUrls()
     {
         yield ['/'];
         yield ['/en/blog/'];
-        yield ['/en/blog/posts/morbi-tempus-commodo-mattis'];
         yield ['/en/login'];
     }