minor #1357 Remove Tag::setName (chr-hertel)

This PR was merged into the main branch.

Discussion
----------

Remove Tag::setName

In this case we can move it to constructor

Commits
-------

ced9eb2 remove Tag::setName

Author: javiereguiluz

data/database.sqlite

@@ -185,16 +185,6 @@ parameters:
 			count: 1
 			path: src/Entity/Post.php
 
-		-
-			message: "#^Method App\\\\Entity\\\\Tag\\:\\:__toString\\(\\) should return string but returns string\\|null\\.$#"
-			count: 1
-			path: src/Entity/Tag.php
-
-		-
-			message: "#^Method App\\\\Entity\\\\Tag\\:\\:jsonSerialize\\(\\) should return string but returns string\\|null\\.$#"
-			count: 1
-			path: src/Entity/Tag.php
-
 		-
 			message: "#^Method App\\\\Entity\\\\User\\:\\:__serialize\\(\\) return type has no value type specified in iterable type array\\.$#"
 			count: 1

phpstan-baseline.neon

@@ -56,8 +56,7 @@ private function loadUsers(ObjectManager $manager): void
     private function loadTags(ObjectManager $manager): void
     {
         foreach ($this->getTagData() as $name) {
-            $tag = new Tag();
-            $tag->setName($name);
+            $tag = new Tag($name);
 
             $manager->persist($tag);
             $this->addReference('tag-'.$name, $tag);

src/DataFixtures/AppFixtures.php

@@ -29,20 +29,18 @@ class Tag implements \JsonSerializable
     #[ORM\Column(type: 'integer')]
     private ?int $id = null;
 
-    #[ORM\Column(type: 'string', unique: true)]
-    private ?string $name = null;
+    public function __construct(
+        #[ORM\Column(type: 'string', unique: true)]
+        private readonly string $name,
+    ) {
+    }
 
     public function getId(): ?int
     {
         return $this->id;
     }
 
-    public function setName(string $name): void
-    {
-        $this->name = $name;
-    }
-
-    public function getName(): ?string
+    public function getName(): string
     {
         return $this->name;
     }

src/Entity/Tag.php

@@ -62,9 +62,7 @@ public function reverseTransform($string): array
         ]);
         $newNames = array_diff($names, $tags);
         foreach ($newNames as $name) {
-            $tag = new Tag();
-            $tag->setName($name);
-            $tags[] = $tag;
+            $tags[] = new Tag($name);
 
             // There's no need to persist these new tags because Doctrine does that automatically
             // thanks to the cascade={"persist"} option in the App\Entity\Post::$tags property.

src/Form/DataTransformer/TagArrayToStringTransformer.php

@@ -72,8 +72,8 @@ public function testDuplicateNames(): void
     public function testUsesAlreadyDefinedTags(): void
     {
         $persistedTags = [
-            $this->createTag('Hello'),
-            $this->createTag('World'),
+            new Tag('Hello'),
+            new Tag('World'),
         ];
         $tags = $this->getMockedTransformer($persistedTags)->reverseTransform('Hello, World, How, Are, You');
 
@@ -89,8 +89,8 @@ public function testUsesAlreadyDefinedTags(): void
     public function testTransform(): void
     {
         $persistedTags = [
-            $this->createTag('Hello'),
-            $this->createTag('World'),
+            new Tag('Hello'),
+            new Tag('World'),
         ];
         $transformed = $this->getMockedTransformer()->transform($persistedTags);
 
@@ -114,15 +114,4 @@ private function getMockedTransformer(array $findByReturnValues = []): TagArrayT
 
         return new TagArrayToStringTransformer($tagRepository);
     }
-
-    /**
-     * This helper method creates a Tag instance for the given tag name.
-     */
-    private function createTag(string $name): Tag
-    {
-        $tag = new Tag();
-        $tag->setName($name);
-
-        return $tag;
-    }
 }