OpenBSD 7.8 will require OpaquePointer for FILE. #84478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please test. |
Member
Author
|
@swift-ci please test macOS platform. |
Member
Author
|
We need to disable SwiftReflectionTest on OpenBSD < 7.8 with this change as well, because there will still be a type mismatch on the Swift side as that calls fwrite/fflush directly. |
3405691582
force-pushed
the
opaque_file
branch
2 times, most recently
from
3c38990 to
f9a9f2c
Compare
Member
Author
|
@swift-ci please test. |
3405691582
force-pushed
the
opaque_file
branch
from
f9a9f2c to
d4b8ce2
Compare
Member
Author
|
@swift-ci please test. |
3405691582
force-pushed
the
opaque_file
branch
from
d4b8ce2 to
d46d128
Compare
Member
Author
|
@swift-ci please test. |
3405691582
force-pushed
the
opaque_file
branch
from
d46d128 to
a8733ab
Compare
Member
Author
|
@swift-ci please test. |
finagolfin
approved these changes
Sep 25, 2025
Member
finagolfin
left a comment
finagolfin
left a comment
There was a problem hiding this comment.
Not familiar with the OpenBSD change, but this will not affect any other platform and you know OpenBSD best, so LGTM with nit.
OpenBSD 7.8 snapshots hide the type information for FILE. Therefore, the types for the standard stdio streams should (regrettably) be OpaquePointer, due to the well-discussed issue of losing type information for forward-declared C types. We explicitly drop to void * in the LibcOverlayShims for backwards compatibility, since OpenBSD 7.8 is not yet released. However, because SwiftReflectionTest uses libc FILE functions like fwrite and fflush directly, this means that building this on 7.7 will still fail because types will mismatch. Instead of adding extra shims, let's just skip building SwiftReflectionTest on 7.7.
3405691582
force-pushed
the
opaque_file
branch
from
a8733ab to
262a484
Compare
Member
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD 7.8 snapshots hide the type information for FILE. Therefore, the types for the standard stdio streams should (regrettably) be OpaquePointer, due to the well-discussed issue of losing type information for forward-declared C types.
We explicitly drop to void * in the LibcOverlayShims for backwards compatibility, since OpenBSD 7.8 is not yet released.