Skip to content

Conversation

@edymtt
Copy link
Contributor

@edymtt edymtt commented Sep 9, 2025

Addresses rdar://126297330

@edymtt edymtt requested a review from shahmishal as a code owner September 9, 2025 14:34
@edymtt edymtt requested review from etcwilde, justice-adams-apple and shahmishal and removed request for shahmishal September 9, 2025 14:34
@edymtt
Copy link
Contributor Author

edymtt commented Sep 9, 2025

@swift-ci please smoke test

@compnerd
Copy link
Member

compnerd commented Sep 9, 2025

@etcwilde wasn't there some rare issue that we had observed a few instances of with the 1.13 release?

@etcwilde
Copy link
Member

etcwilde commented Sep 9, 2025

It was with 1.12.x. I've been living on 1.13.1 for a few months now and haven't seen issues, but I'd like confirmation that it has been tested by a few others before we bump the version for everyone.

1.12.x had a few issues that were fixed in 1.13.x that may be related:

Basically, there was an out-of-bounds access in the ninja dependency graph tracking file.
They were fixed in ninja-build/ninja#2489.

@edymtt
Copy link
Contributor Author

edymtt commented Sep 18, 2025

I have been using this version lately, and not hitting any issue.

I've also run rebuilds overnight on macOS and Linux, simulating changing the name of a diagnostics used in TypeCheckAnalysis.cpp and rebulding bin/swift-frontend afterwards, and did not hit any issue.

@edymtt edymtt merged commit e419d30 into swiftlang:main Sep 18, 2025
3 checks passed
@edymtt edymtt deleted the edymtt/update-to-ninja-1.13.1 branch September 18, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants