Tests: Use variant module triple #83579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@swift-ci please test |
This switches from using lit.cfg to attempt to recompute the module triple to using the triple computed in CMake to ensure consistency. This is a better source of truth than having many sources everywhere. In case anyone sees this and is wondering, the "target triple" refers to the triple that the compiler is built for, while the "variant triple" refers to the platform that the tests and runtimes are built for.
etcwilde
force-pushed
the
ewilde/test-use-module-triple
branch
from
b37e43f to
1f06214
Compare
Member
Author
|
@swift-ci please test |
Member
Author
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from using lit.cfg to attempt to recompute the module triple to using the triple computed in CMake to ensure consistency. This is a better source of truth than having many sources everywhere.
In case anyone sees this and is wondering, the "target triple" refers to the triple that the compiler is built for, while the "variant triple" refers to the platform that the tests and runtimes are built for.