[Concurrency] Prevent negative sleeps from sleeping forever. #82563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci Please smoke test |
Requests to sleep until a negative timestamp would result in sleeping until `UINT64_MAX` nanoseconds from the start of the relevant clock, which is about 585 years. rdar://154346018
al45tair
force-pushed
the
eng/PR-154346018
branch
from
f9f212d to
8079103
Compare
Contributor
Author
|
Just updated it to check |
Contributor
Author
|
@swift-ci Please smoke test |
ktoso
approved these changes
Jun 27, 2025
mikeash
approved these changes
Jun 27, 2025
Contributor
mikeash
left a comment
mikeash
left a comment
There was a problem hiding this comment.
It would be better if a negative sleep caused execution to resume before the sleep call, but I suppose this will do for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests to sleep until a negative timestamp would result in sleeping until
UINT64_MAXnanoseconds from the start of the relevant clock, which is about 585 years.rdar://154346018