🍒 [demangling] add new wrapper API #82562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS |
Contributor
Author
|
@swift-ci please test macos |
Contributor
Author
|
@swift-ci please test macOS |
2 similar comments
Contributor
Author
|
@swift-ci please test macOS |
Contributor
Author
|
@swift-ci please test macOS |
adrian-prantl
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Add a new wrapper API for
Context::demangleSymbolAsString, avoiding to manually instantiate aContextobject to use the method.Scope:
This change only adds a wrapper to an existing API, in the demangler.
Issues:
Original PRs:
Risk:
Low, the logic of the wrapper is simple.
Testing:
Built against the LLVM patches which add demangling syntax highlighting.
Reviewers: