Skip to content

Conversation

@meg-gupta
Copy link
Contributor

@meg-gupta meg-gupta commented May 7, 2025

Asserts in LifetimeDependence was previously disabled during the bringup of ~Escapable Optional because they were firing on AsyncNinja. I am enabling it back because I cannot reproduce it. Also turning it into ASSERT which will fire in no-asserts build in case this turns out to be an intermittent failure.

@meg-gupta
Copy link
Contributor Author

@swift-ci test source compatibility

@meg-gupta
Copy link
Contributor Author

@swift-ci build toolchain

@meg-gupta
Copy link
Contributor Author

@swift-ci test

@meg-gupta meg-gupta marked this pull request as ready for review May 8, 2025 17:30
@meg-gupta meg-gupta requested review from atrick and lorentey May 8, 2025 18:05
Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks!

@meg-gupta meg-gupta merged commit 1cdfd01 into swiftlang:main May 8, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants