From 1f00ffe42c17224e3eded46e85937ae642481791 Mon Sep 17 00:00:00 2001
From: Ben Langmuir <ben.langmuir@gmail.com>
Date: Tue, 6 Aug 2024 16:10:42 -0700
Subject: [PATCH] Revert "[immediate] Load Foundation early enough for
 bridging"

---
 include/swift/AST/DiagnosticsFrontend.def     |  2 --
 include/swift/Immediate/Immediate.h           |  4 ---
 lib/FrontendTool/FrontendTool.cpp             |  7 -----
 lib/Immediate/Immediate.cpp                   | 27 -------------------
 .../Interpreter/foundation-bridge-error.swift | 25 -----------------
 5 files changed, 65 deletions(-)
 delete mode 100644 test/Interpreter/foundation-bridge-error.swift

diff --git a/include/swift/AST/DiagnosticsFrontend.def b/include/swift/AST/DiagnosticsFrontend.def
index 8298f3b37085f..361bd1cddbaf7 100644
--- a/include/swift/AST/DiagnosticsFrontend.def
+++ b/include/swift/AST/DiagnosticsFrontend.def
@@ -115,8 +115,6 @@ ERROR(error_immediate_mode_missing_library,none,
       (unsigned, StringRef))
 ERROR(error_immediate_mode_primary_file,none,
       "immediate mode is incompatible with -primary-file", ())
-WARNING(warning_immediate_mode_cannot_load_foundation,none,
-        "immediate mode failed to load Foundation: %0", (StringRef))
 ERROR(error_missing_frontend_action,none,
       "no frontend action was selected", ())
 ERROR(error_invalid_source_location_str,none,
diff --git a/include/swift/Immediate/Immediate.h b/include/swift/Immediate/Immediate.h
index 8518ba0ff67fd..10f0425290bfb 100644
--- a/include/swift/Immediate/Immediate.h
+++ b/include/swift/Immediate/Immediate.h
@@ -24,7 +24,6 @@
 
 namespace swift {
   class CompilerInstance;
-  class DiagnosticEngine;
   class IRGenOptions;
   class SILOptions;
   class SILModule;
@@ -45,9 +44,6 @@ namespace swift {
 
   int RunImmediatelyFromAST(CompilerInstance &CI);
 
-  /// On platforms that support ObjC bridging from the Foundation framework,
-  /// ensure that Foundation is loaded early enough. Otherwise does nothing.
-  void loadFoundationIfNeeded(DiagnosticEngine &Diags);
 } // end namespace swift
 
 #endif // SWIFT_IMMEDIATE_IMMEDIATE_H
diff --git a/lib/FrontendTool/FrontendTool.cpp b/lib/FrontendTool/FrontendTool.cpp
index c3be25afb8e13..703ccd99c3d76 100644
--- a/lib/FrontendTool/FrontendTool.cpp
+++ b/lib/FrontendTool/FrontendTool.cpp
@@ -1955,13 +1955,6 @@ int swift::performFrontend(ArrayRef<const char *> Args,
     return finishDiagProcessing(1, /*verifierEnabled*/ false);
   }
 
-  // Scripts that use the Foundation framework need it loaded early for bridging
-  // to work correctly on Darwin platforms. On other platforms this is a no-op.
-  if (Invocation.getFrontendOptions().RequestedAction ==
-      FrontendOptions::ActionType::Immediate) {
-    loadFoundationIfNeeded(Instance->getDiags());
-  }
-
   // Don't ask clients to report bugs when running a script in immediate mode.
   // When a script asserts the compiler reports the error with the same
   // stacktrace as a compiler crash. From here we can't tell which is which,
diff --git a/lib/Immediate/Immediate.cpp b/lib/Immediate/Immediate.cpp
index cfbfc5ad77264..f83b1b05df7d1 100644
--- a/lib/Immediate/Immediate.cpp
+++ b/lib/Immediate/Immediate.cpp
@@ -432,30 +432,3 @@ int swift::RunImmediatelyFromAST(CompilerInstance &CI) {
 
   return *Result;
 }
-
-void swift::loadFoundationIfNeeded(DiagnosticEngine &Diags) {
-#if defined(__APPLE__)
-  const char *FoundationPath =
-      "/System/Library/Frameworks/Foundation.framework/Foundation";
-  void *handle = dlopen(FoundationPath, RTLD_NOLOAD);
-  if (handle) {
-    // Foundation is already loaded. Use dlclose to release the ref-count that
-    // was incremented by dlopen and return.
-    dlclose(handle);
-    return;
-  } else {
-    // Foundation is not yet loaded. Load it now and leak the handle.
-    // FIXME: it is fragile to load here, as there is no guarantee the swift
-    // runtime has not initialized already. As the compiler adds more swift code
-    // we may need to move this or find another solution.
-    handle = dlopen(FoundationPath, RTLD_LAZY | RTLD_GLOBAL);
-    if (!handle)
-      Diags.diagnose(SourceLoc(),
-                     diag::warning_immediate_mode_cannot_load_foundation,
-                     dlerror());
-  }
-
-#else
-  // Nothing to do.
-#endif
-}
diff --git a/test/Interpreter/foundation-bridge-error.swift b/test/Interpreter/foundation-bridge-error.swift
deleted file mode 100644
index bfb3a7c80d287..0000000000000
--- a/test/Interpreter/foundation-bridge-error.swift
+++ /dev/null
@@ -1,25 +0,0 @@
-// Check that we can access localizedDescription, which crashes in the runtime
-// if Foundation is loaded after the runtime is already initialized on Darwin.
-
-// REQUIRES: executable_test
-// REQUIRES: objc_interop
-// REQUIRES: OS=macosx
-
-// FIXME: There's a separate bridging error with the just-built stdlib on CI
-// nodes.
-// REQUIRES: use_os_stdlib
-
-// RUN: %target-jit-run %s
-// RUN: DYLD_INSERT_LIBRARIES=/System/Library/Frameworks/Foundation.framework/Foundation %target-jit-run %s
-
-import Foundation
-
-print("Insert Libraries: \(ProcessInfo.processInfo.environment["DYLD_INSERT_LIBRARIES"] ?? "<nil>")")
-
-enum SomeError: LocalizedError {
- case fail
-}
-
-let err = SomeError.fail
-let path = (#file as NSString).lastPathComponent
-let desc = err.localizedDescription
\ No newline at end of file