[6.0][Concurrency] Further prevent crashes in legacy mode of isSameExecutor concurrency #73839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
Contributor
Author
|
@swift-ci please test |
ktoso
added
concurrency
DougGregor
approved these changes
May 23, 2024
ktoso
changed the title
resolves rdar://128425368 resolves rdar://127400013
…ain thread that this is equal
…r swift6/legacy modes
ktoso
force-pushed
the
pick-6-pick-concurrency-isCurrent-more-fixes
branch
from
a41d2a8 to
01d0958
Compare
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
Last commit here is unbreaking embedded, pick from: #73934 |
ktoso
force-pushed
the
pick-6-pick-concurrency-isCurrent-more-fixes
branch
from
772fc1c to
6b2e9b1
Compare
Contributor
Author
|
@swift-ci please test |
ktoso
force-pushed
the
pick-6-pick-concurrency-isCurrent-more-fixes
branch
from
275dff8 to
135213e
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This cleans up interactions with the "legacy mode" where we're not allowed to crash in the isCurrentExecutor impl.
Scope/Impact: Dynamic actor isolation checks are inserted by Swift 6. Without this patch they would crash existing applications without them recompiling. This patch corrects logic to only start doing so when recompiled against new SDK. It also corrects some logic that would have prevented
checkIsolatedfrom being invoked in some cases.Risk: Medium, the change is fleshing out logic in
swift_task_isCurrentExecutorImplinteractions between flags. However we took great lengths to verify this logic is now correct.Testing: Verified manually; Improved tests to now run in swift 6 AND legacy mode.
Reviewed by: @hborla @mikeash
Original PR: #73813
Radar: rdar://127400013