[6.0🍒][Explicit Module Builds] C++ Interoperability mode fixes #73767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sub-invocations and dependency scanner
…bled. We cannot always rely on being able to do so only as an overlay query upon loading 'requires cplusplus' modulemap modules. The 'requires' statement only applies to submodules, and we may not be able to query language feature modulemap attributes in dependency scanning context.
Contributor
Author
|
@swift-ci test |
nkcsgexi
approved these changes
May 20, 2024
…it-cxx-module-import`
artemcm
force-pushed
the
60DepScanCPPInterop
branch
from
352f3c2 to
298521b
Compare
Contributor
Author
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #69706
Explanation: This change is a collection of fixes that makes C++ Interoperability feature compatible with Explicitly-built modules.
Cxxmodule when C++ Interop is enabled.requires cplusplusmodulemap modules. Therequiresstatement only applies to submodules, and we may not be able to query language feature modulemap attributes in dependency scanning context.Cxximport with-disable-implicit-cxx-module-importRisk: Low-Moderate. This change only affects code-paths for the C++ Interop feature. Primarily, though not exclusively when used in combination with Explicitly-Built modules.
Testing: Existing automated tests ensure that this change does not affect existing C++ Interop functionality.
Reviewed By: @egorzhdan