[6.0][Runtime] Don't attempt to look up prespecialized metadata involving pointers outside the shared cache. #72881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ving pointers outside the shared cache. The descriptor and arguments for prespecialized metadata will always be in the shared cache. Skip creating the mangling for any lookup involving pointers outside the shared cache, as an optimization. rdar://125974577 (cherry picked from commit 98229fe)
Contributor
Author
|
Explanation: Computing the mangled name for a prespecialized generic metadata request is somewhat expensive. This optimization avoids it altogether when the addresses of the descriptor or generic arguments mean we know for sure we won't find one anyway. |
Contributor
Author
|
@swift-ci please test |
Contributor
|
@swift-ci Please test macOS platform |
Contributor
Author
|
@swift-ci please test macos platform |
tbkka
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #72870 to
release/6.0.The descriptor and arguments for prespecialized metadata will always be in the shared cache. Skip creating the mangling for any lookup involving pointers outside the shared cache, as an optimization.
rdar://125974577