[6.0🍒] Revert "On 'canImport' of Clang submodules of modules with an umbrella header, attempt to infer the submodule" #72880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a header, attempt to infer the submodule"
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #72879
Reverts #72129 from the
release/6.0branch.Explanation: This change had an unintended breaking effect - it causes
#canImportclauses with non-existing submodules to succeed, at times.Risk: Low. This change reverts a recent bugfix that turned out to be incomplete. The bug it fixed had been around for years, so this just reverts things to the status-quo.
Testing: Original change had an automated test which this PR reverts. Since this gets us back to where we were prior to this change, no additional testing is required.
Reviewed By: @cachemeifyoucan