Add package name to public swiftinterface #69517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambiguity during lookup when there are multiple public or inlinalbe package decls in public interfaces. This PR adds a package name to public swiftinterface and lets typecheck look up the package name to narrow down the scope of access to package decls from an external module. Resolves rdar://117699160
elsh
requested review from
AnthonyLatsis,
artemcm,
hborla,
slavapestov and
xedin
as code owners
Contributor
Author
|
@swift-ci smoke test |
tshortli
approved these changes
Oct 30, 2023
nkcsgexi
reviewed
Oct 30, 2023
Contributor
nkcsgexi
left a comment
nkcsgexi
left a comment
There was a problem hiding this comment.
Thank you for the quick fix, Ellie! Some minor comments inline.
xymus
reviewed
Oct 30, 2023
nkcsgexi
reviewed
Oct 30, 2023
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test linux |
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
@swift-ci smoke test |
Contributor
Author
|
Blocked by "fatal error: module map file 'llbuildBasic.build/module.modulemap' not found" error on CI cc @shahmishal |
Contributor
|
@swift-ci Please smoke test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package name is only printed in private swiftinterface. This causes
ambiguity during lookup when there are multiple public or inlinalbe
package decls in public interfaces. This PR adds a package name to
public swiftinterface and lets typecheck look up the package name
to narrow down the scope of access to package decls from an external
module.
Resolves rdar://117699160