[stdlib] Add @discardableResult to Set.insert’s AnyHashable overload #68067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike the core Set.insert, this utility declaration wasn’t declared @discardableOverload, introducing an undesirable inconsistency. rdar://114008680
Member
Author
|
Cc @stephentyrone This is technically a public API change; however, it is merely resolving an undesirable/unintentional inconsistency, so it's probably fine to do this without a Swift Evolution process. I can't think of a way this change could possibly have an adverse effect in client code. (Beyond making code that relies on |
Member
Author
|
@swift-ci test |
Member
Author
|
The Windows CI run has experienced an unrelated timeout. |
stephentyrone
approved these changes
Aug 23, 2023
Contributor
|
Make it so. |
Contributor
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the core Set.insert, this utility declaration wasn’t declared
@discardableResult.rdar://114008680