re-enable executor_deinit1.swift
#67897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I put this test in originally XFAIL'd because the deinit for the actor was not being run before program exit. It was expected to run because it's not top-level code so there is a release of the object before returning from RunIt.main. My guess is that the root cause of the original bug of it not running the deinit was because of the "executor stickiness" that was present in Swift concurrency prior to SE-338. Today it seems that this isn't an issue so we may as well have this test back. resolves rdar://77397981 resolves swiftlang#56817
Member
Author
|
@swift-ci smoke test |
Member
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I put this test in originally XFAIL'd because the deinit for the actor was not being run before program exit. It was expected to run because it's not top-level code so there is a release of the object before returning from RunIt.main.
My guess is that the root cause of the original
bug of it not running the deinit was because of
the "executor stickiness" that was present in
Swift concurrency prior to SE-338. Today it
seems that this isn't an issue so we may as well
have this test back.
resolves rdar://77397981
resolves #56817